Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 75273005: Set DPI before using GetPdfPaperSizeDeviceUnits (Closed)

Created:
7 years, 1 month ago by cimamoglu (inactive)
Modified:
7 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Set DPI before using GetPdfPaperSizeDeviceUnits Not setting DPI causes a modal error dialog to be shown for Android printing code. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235825

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M printing/printing_context_android.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
cimamoglu1
7 years, 1 month ago (2013-11-18 16:47:43 UTC) #1
whywhat
lgtm
7 years, 1 month ago (2013-11-18 17:53:12 UTC) #2
Vitaly Buka (NO REVIEWS)
lgtm
7 years, 1 month ago (2013-11-18 19:28:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cimamoglu@chromium.org/75273005/1
7 years, 1 month ago (2013-11-18 19:31:24 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-11-18 21:53:15 UTC) #5
Message was sent while issue was closed.
Change committed as 235825

Powered by Google App Engine
This is Rietveld 408576698