Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1209)

Unified Diff: Source/core/rendering/RenderBlockFlow.h

Issue 752723004: Use references in RenderBlock and RenderBlockFlow methods (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/RenderBlockFlow.h
diff --git a/Source/core/rendering/RenderBlockFlow.h b/Source/core/rendering/RenderBlockFlow.h
index 7cbec609fba1d7c02fee821b6cf1d40671af93ba..b8b9bec203e9885e7cc2b796dc0ea71a0fdfd9d9 100644
--- a/Source/core/rendering/RenderBlockFlow.h
+++ b/Source/core/rendering/RenderBlockFlow.h
@@ -212,13 +212,13 @@ public:
if (isHorizontalWritingMode())
return child->x() + child->renderer()->marginLeft();
- return child->x() + marginBeforeForChild(child->renderer());
+ return child->x() + marginBeforeForChild(*(child->renderer()));
Julien - ping for review 2014/11/26 18:52:35 We should make FloatingObject return a reference t
Sunil Ratnu 2014/11/27 12:02:54 Lets keep FloatingObject conversion in a separate
}
LayoutUnit yPositionForFloatIncludingMargin(const FloatingObject* child) const
{
if (isHorizontalWritingMode())
- return child->y() + marginBeforeForChild(child->renderer());
+ return child->y() + marginBeforeForChild(*(child->renderer()));
return child->y() + child->renderer()->marginTop();
}

Powered by Google App Engine
This is Rietveld 408576698