Source/core/frame/LocalDOMWindow.cpp - Issue 752713002: Make getComputedStyle throw for incorrect first parameter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/LocalDOMWindow.cpp

Issue 752713002: Make getComputedStyle throw for incorrect first parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address issues Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/css/getComputedStyle/computed-style-non-element-parameter-expected.txt ('k') | Source/core/frame/Window.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/frame/LocalDOMWindow.cpp

diff --git a/Source/core/frame/LocalDOMWindow.cpp b/Source/core/frame/LocalDOMWindow.cpp

index 8f0526c6ef991b3ebcedfe68ac7414235c1be00a..c6e43ae7b0383c30f2ab81e5a0b8e8aa59865238 100644

--- a/Source/core/frame/LocalDOMWindow.cpp

+++ b/Source/core/frame/LocalDOMWindow.cpp

@@ -1384,9 +1384,7 @@ StyleMedia* LocalDOMWindow::styleMedia() const

PassRefPtrWillBeRawPtr<CSSStyleDeclaration> LocalDOMWindow::getComputedStyle(Element* elt, const String& pseudoElt) const

{

- if (!elt)

- return nullptr;

+ ASSERT(elt);

return CSSComputedStyleDeclaration::create(elt, false, pseudoElt);

}