Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 752683002: Break Sky's dependency on cc (Closed)

Created:
6 years, 1 month ago by abarth-chromium
Modified:
6 years, 1 month ago
Reviewers:
esprehn, rafaelw, ojan
CC:
esprehn, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Break Sky's dependency on cc We no longer link with cc. Instead, we use a simple, direct-to-Ganesh rendering pipeline. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/eb7c1b9a29c37635cf92afa1894b775785f2003a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3370 lines) Patch
M sky/viewer/BUILD.gn View 3 chunks +0 lines, -6 lines 0 comments Download
D sky/viewer/cc/BUILD.gn View 1 chunk +0 lines, -76 lines 0 comments Download
D sky/viewer/cc/sky_viewer_cc_export.h View 1 chunk +0 lines, -20 lines 0 comments Download
D sky/viewer/cc/web_animation_curve_common.h View 1 chunk +0 lines, -20 lines 0 comments Download
D sky/viewer/cc/web_animation_curve_common.cc View 1 chunk +0 lines, -28 lines 0 comments Download
D sky/viewer/cc/web_animation_impl.h View 1 chunk +0 lines, -65 lines 0 comments Download
D sky/viewer/cc/web_animation_impl.cc View 1 chunk +0 lines, -170 lines 0 comments Download
D sky/viewer/cc/web_animation_unittest.cc View 1 chunk +0 lines, -60 lines 0 comments Download
D sky/viewer/cc/web_blend_mode.h View 1 chunk +0 lines, -107 lines 0 comments Download
D sky/viewer/cc/web_compositor_support_impl.h View 1 chunk +0 lines, -50 lines 0 comments Download
D sky/viewer/cc/web_compositor_support_impl.cc View 1 chunk +0 lines, -92 lines 0 comments Download
D sky/viewer/cc/web_content_layer_impl.h View 1 chunk +0 lines, -56 lines 0 comments Download
D sky/viewer/cc/web_content_layer_impl.cc View 1 chunk +0 lines, -69 lines 0 comments Download
D sky/viewer/cc/web_external_bitmap_impl.h View 1 chunk +0 lines, -46 lines 0 comments Download
D sky/viewer/cc/web_external_bitmap_impl.cc View 1 chunk +0 lines, -46 lines 0 comments Download
D sky/viewer/cc/web_external_texture_layer_impl.h View 1 chunk +0 lines, -72 lines 0 comments Download
D sky/viewer/cc/web_external_texture_layer_impl.cc View 1 chunk +0 lines, -125 lines 0 comments Download
D sky/viewer/cc/web_filter_animation_curve_impl.h View 1 chunk +0 lines, -50 lines 0 comments Download
D sky/viewer/cc/web_filter_animation_curve_impl.cc View 1 chunk +0 lines, -57 lines 0 comments Download
D sky/viewer/cc/web_filter_operations_impl.h View 1 chunk +0 lines, -49 lines 0 comments Download
D sky/viewer/cc/web_filter_operations_impl.cc View 1 chunk +0 lines, -95 lines 0 comments Download
D sky/viewer/cc/web_float_animation_curve_impl.h View 1 chunk +0 lines, -53 lines 0 comments Download
D sky/viewer/cc/web_float_animation_curve_impl.cc View 1 chunk +0 lines, -58 lines 0 comments Download
D sky/viewer/cc/web_float_animation_curve_unittest.cc View 1 chunk +0 lines, -234 lines 0 comments Download
D sky/viewer/cc/web_image_layer_impl.h View 1 chunk +0 lines, -34 lines 0 comments Download
D sky/viewer/cc/web_image_layer_impl.cc View 1 chunk +0 lines, -38 lines 0 comments Download
D sky/viewer/cc/web_layer_impl.h View 1 chunk +0 lines, -131 lines 0 comments Download
D sky/viewer/cc/web_layer_impl.cc View 1 chunk +0 lines, -350 lines 0 comments Download
D sky/viewer/cc/web_layer_impl_fixed_bounds.h View 1 chunk +0 lines, -50 lines 0 comments Download
D sky/viewer/cc/web_layer_impl_fixed_bounds.cc View 1 chunk +0 lines, -100 lines 0 comments Download
D sky/viewer/cc/web_layer_impl_fixed_bounds_unittest.cc View 1 chunk +0 lines, -179 lines 0 comments Download
D sky/viewer/cc/web_to_cc_animation_delegate_adapter.h View 1 chunk +0 lines, -40 lines 0 comments Download
D sky/viewer/cc/web_to_cc_animation_delegate_adapter.cc View 1 chunk +0 lines, -35 lines 0 comments Download
D sky/viewer/cc/web_transform_animation_curve_impl.h View 1 chunk +0 lines, -52 lines 0 comments Download
D sky/viewer/cc/web_transform_animation_curve_impl.cc View 1 chunk +0 lines, -61 lines 0 comments Download
D sky/viewer/cc/web_transform_operations_impl.h View 1 chunk +0 lines, -41 lines 0 comments Download
D sky/viewer/cc/web_transform_operations_impl.cc View 1 chunk +0 lines, -68 lines 0 comments Download
M sky/viewer/content_handler_impl.h View 1 chunk +4 lines, -6 lines 0 comments Download
M sky/viewer/content_handler_impl.cc View 4 chunks +5 lines, -10 lines 0 comments Download
M sky/viewer/document_view.h View 4 chunks +1 line, -19 lines 0 comments Download
M sky/viewer/document_view.cc View 7 chunks +1 line, -43 lines 0 comments Download
M sky/viewer/platform/platform_impl.h View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/viewer/platform/platform_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
D sky/viewer/platform/weblayertreeview_impl.h View 1 chunk +0 lines, -142 lines 0 comments Download
D sky/viewer/platform/weblayertreeview_impl.cc View 1 chunk +0 lines, -254 lines 0 comments Download
M sky/viewer/viewer.cc View 3 chunks +2 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
abarth-chromium
6 years, 1 month ago (2014-11-21 20:10:27 UTC) #2
esprehn
Crazy, this means we now raster on the main thread right? It also looks like ...
6 years, 1 month ago (2014-11-21 20:14:02 UTC) #3
esprehn
lgtm
6 years, 1 month ago (2014-11-21 20:14:08 UTC) #4
abarth-chromium
On 2014/11/21 at 20:14:02, esprehn wrote: > Crazy, this means we now raster on the ...
6 years, 1 month ago (2014-11-21 20:18:42 UTC) #5
abarth-chromium
6 years, 1 month ago (2014-11-21 20:21:44 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
eb7c1b9a29c37635cf92afa1894b775785f2003a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698