Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 752673002: Cache HttpRequest in test. (Closed)

Created:
6 years, 1 month ago by ahe
Modified:
6 years ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Merged with r41951. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M dart/tests/try/web/web_compiler_test_case.dart View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
ahe
In checked mode 1/6 of the time in try/web/incremental_compilation_update_test.dart was spent waiting for HTTP requests.
6 years, 1 month ago (2014-11-21 19:05:06 UTC) #2
ahe
On 2014/11/21 19:05:06, ahe wrote: > In checked mode 1/6 of the time in > ...
6 years, 1 month ago (2014-11-21 19:08:50 UTC) #3
Johnni Winther
lgtm
6 years ago (2014-11-24 10:37:46 UTC) #4
ahe
6 years ago (2014-11-25 13:55:31 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 41952 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698