Issue 752633004: Switch codereview.settings to git.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 752633004: Switch codereview.settings to git. (Closed)

Created:
6 years ago by Michael Achenbach

Modified:
6 years ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@3.30

Project:
v8

Visibility:
Public.

More Reviews

Description

Switch codereview.settings to git. TBR=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=eebbf6319a79e759c307eaf1ce85e1ffb6878298

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	codereview.settings	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Michael Achenbach

Committed patchset #1 (id:1) manually as eebbf6319a79e759c307eaf1ce85e1ffb6878298 (presubmit successful).

6 years ago (2014-11-24 10:21:10 UTC) #2

Yang

6 years ago (2014-11-24 10:24:14 UTC) #3

Message was sent while issue was closed.

On 2014/11/24 10:21:10, Michael Achenbach wrote:
> Committed patchset #1 (id:1) manually as
> eebbf6319a79e759c307eaf1ce85e1ffb6878298 (presubmit successful).

lgtm.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages