Add a browser test to verify that double-closing a notification does not crash.

chrome/browser/notifications/notification_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <deque>
 #include <string>
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/command_line.h"
@@ skipping 132 matching lines @@
   bool CancelNotification(const char* notification_id, Browser* browser);
   bool PerformActionOnInfoBar(Browser* browser,
                               InfobarAction action,
                               size_t infobar_index,
                               int tab_index);
   void GetPrefsByContentSetting(ContentSetting setting,
                                 ContentSettingsForOneType* settings);
   bool CheckOriginInSetting(const ContentSettingsForOneType& settings,
                             const GURL& origin);
 
+  GURL GetTestPageURLForFile(const std::string& file) const {
+    return embedded_test_server()->GetURL(
+      std::string("/notifications/") + file);
+  }
+
   GURL GetTestPageURL() const {
-    return embedded_test_server()->GetURL(
-      "/notifications/notification_tester.html");
+    return GetTestPageURLForFile("notification_tester.html");
   }
 
  private:
   void DropOriginPreference(const GURL& origin);
 };
 
 int NotificationsTest::GetNotificationCount() {
   return message_center::MessageCenter::Get()->NotificationCount();
 }
 
@@ skipping 716 matching lines @@
   result = CreateNotification(
       browser(), true, "invalid.png", "Title1", "Body1", "chat");
   EXPECT_NE("-1", result);
 
   notifications = message_center::MessageCenter::Get()->GetPopupNotifications();
   ASSERT_EQ(1u, notifications.size());
 
   notification = *notifications.rbegin();
   EXPECT_TRUE(notification->icon().IsEmpty());
 }
+
+IN_PROC_BROWSER_TEST_F(NotificationsTest, TestNotificationDoubleClose) {
+  ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
+  AllowAllOrigins();
+
+  ui_test_utils::NavigateToURL(
+      browser(), GetTestPageURLForFile("notification-double-close.html"));
+  ASSERT_EQ(0, GetNotificationPopupCount());
+
+  std::string result = CreateNotification(
+      browser(), true, "", "Title1", "Body1", "chat");
+  EXPECT_NE("-1", result);
+
+  ASSERT_EQ(1, GetNotificationCount());
+  message_center::NotificationList::Notifications notifications =
+      message_center::MessageCenter::Get()->GetVisibleNotifications();
+  message_center::MessageCenter::Get()->RemoveNotification(
+      (*notifications.rbegin())->id(),
+      true);  // by_user
+
+  ASSERT_EQ(0, GetNotificationCount());
+
+  // Calling WebContents::IsCrashed() will return FALSE here, even if the WC did
+  // crash. Work around this timing issue by creating another notification,
+  // which requires interaction with the renderer process.
+  result = CreateNotification(browser(), true, "", "Title1", "Body1", "chat");
+  EXPECT_NE("-1", result);
+}