 Chromium Code Reviews
 Chromium Code Reviews Issue 75253002:
  DevTools: [Elements] Implement "Copy CSS Path" context menu item for elements  (Closed) 
  Base URL: svn://svn.chromium.org/blink/trunk
    
  
    Issue 75253002:
  DevTools: [Elements] Implement "Copy CSS Path" context menu item for elements  (Closed) 
  Base URL: svn://svn.chromium.org/blink/trunk| Index: Source/devtools/front_end/DOMAgent.js | 
| diff --git a/Source/devtools/front_end/DOMAgent.js b/Source/devtools/front_end/DOMAgent.js | 
| index 45467bc785d2b124fa86413c1df121a4feaaf940..3f589e33424b7822f4d9653e2df640e4cdb7838f 100644 | 
| --- a/Source/devtools/front_end/DOMAgent.js | 
| +++ b/Source/devtools/front_end/DOMAgent.js | 
| @@ -119,13 +119,13 @@ WebInspector.DOMNode.PseudoElementNames = { | 
| * @param {string} value | 
| * @param {boolean} optimized | 
| */ | 
| -WebInspector.DOMNode.XPathStep = function(value, optimized) | 
| +WebInspector.DOMNode.PathStep = function(value, optimized) | 
| { | 
| this.value = value; | 
| this.optimized = optimized; | 
| } | 
| -WebInspector.DOMNode.XPathStep.prototype = { | 
| +WebInspector.DOMNode.PathStep.prototype = { | 
| toString: function() | 
| { | 
| return this.value; | 
| @@ -416,6 +416,14 @@ WebInspector.DOMNode.prototype = { | 
| /** | 
| * @param {boolean} optimized | 
| */ | 
| + copyCSSPath: function(optimized) | 
| + { | 
| + InspectorFrontendHost.copyText(this.cssPath(optimized)); | 
| + }, | 
| + | 
| + /** | 
| + * @param {boolean} optimized | 
| + */ | 
| copyXPath: function(optimized) | 
| { | 
| InspectorFrontendHost.copyText(this.xPath(optimized)); | 
| @@ -671,6 +679,104 @@ WebInspector.DOMNode.prototype = { | 
| * @param {boolean} optimized | 
| * @return {string} | 
| */ | 
| + cssPath: function(optimized) | 
| + { | 
| + if (this._nodeType !== Node.ELEMENT_NODE) | 
| + return ""; | 
| + | 
| + var steps = []; | 
| + var contextNode = this; | 
| + while (contextNode) { | 
| + var step = contextNode._cssPathValue(optimized); | 
| + if (!step) | 
| + break; // Error - bail out early. | 
| + steps.push(step); | 
| + if (step.optimized) | 
| + break; | 
| + contextNode = contextNode.parentNode; | 
| + } | 
| + | 
| + steps.reverse(); | 
| + return steps.join(" > "); | 
| + }, | 
| + | 
| + /** | 
| + * @param {boolean} optimized | 
| + * @return {WebInspector.DOMNode.PathStep} | 
| + */ | 
| + _cssPathValue: function(optimized) | 
| + { | 
| + if (this._nodeType !== Node.ELEMENT_NODE) | 
| + return null; | 
| + if (optimized) { | 
| + if (this.getAttribute("id")) | 
| + return new WebInspector.DOMNode.PathStep("#" + this.getAttribute("id"), true); | 
| + var nodeNameLower = this._nodeName.toLowerCase(); | 
| + if (nodeNameLower === "body" || nodeNameLower === "head" || nodeNameLower === "html") | 
| + return new WebInspector.DOMNode.PathStep(this.nodeNameInCorrectCase(), true); | 
| + } | 
| + var nodeName = this.nodeNameInCorrectCase(); | 
| + var parent = this.parentNode; | 
| + if (!parent || parent._nodeType === Node.DOCUMENT_NODE) | 
| + return new WebInspector.DOMNode.PathStep(nodeName, true); | 
| + | 
| + /** | 
| + * @param {WebInspector.DOMNode} node | 
| + * @return {Object} | 
| 
aandrey
2013/11/18 15:36:26
@return {!Object.<string, boolean>}
 | 
| + */ | 
| + function elementClassNames(node) | 
| + { | 
| + return (node.getAttribute("class") || "").split(/\s+/g).keySet(); | 
| 
aandrey
2013/11/18 15:36:26
again, empty strings.
a = document.createElement(
 | 
| + } | 
| + | 
| + var uniqueClassNames = elementClassNames(this); | 
| + var uniqueClassNamesLeft = 0; | 
| + for (var name in uniqueClassNames) | 
| + ++uniqueClassNamesLeft; | 
| + var needsClassNames = false; | 
| + var needsNthChild = false; | 
| + var ownIndex = -1; | 
| + var siblings = parent.children(); | 
| + for (var i = 0; (ownIndex === -1 || !needsNthChild) && i < siblings.length; ++i) { | 
| + var sibling = siblings[i]; | 
| + if (sibling === this) { | 
| + ownIndex = i; | 
| + continue; | 
| + } | 
| + if (sibling.nodeNameInCorrectCase() !== nodeName) | 
| + continue; | 
| + if (!uniqueClassNamesLeft) { | 
| + needsNthChild = true; | 
| + continue; | 
| + } | 
| + | 
| + needsClassNames = true; | 
| + var siblingClassNames = elementClassNames(sibling); | 
| + for (var siblingClass in siblingClassNames) { | 
| + if (!uniqueClassNames.hasOwnProperty(siblingClass)) | 
| + continue; | 
| + delete uniqueClassNames[siblingClass]; | 
| + if (!--uniqueClassNamesLeft) { | 
| + needsNthChild = true; | 
| + break; | 
| 
aandrey
2013/11/18 15:36:26
this could break while ownIndex is still -1
 | 
| + } | 
| + } | 
| + } | 
| + | 
| + var result = nodeName; | 
| + if (needsClassNames && uniqueClassNamesLeft) { | 
| + for (var className in uniqueClassNames) | 
| + result += "." + className; | 
| + } | 
| + if (needsNthChild) | 
| + result += ":nth-child(" + (ownIndex + 1) + ")"; | 
| 
aandrey
2013/11/18 15:36:26
ownIndex may be -1 here. add a test.
 
aandrey
2013/11/18 15:43:05
Ah, seems I was wrong.
 | 
| + return new WebInspector.DOMNode.PathStep(result, false); | 
| + }, | 
| + | 
| + /** | 
| + * @param {boolean} optimized | 
| + * @return {string} | 
| + */ | 
| xPath: function(optimized) | 
| { | 
| if (this._nodeType === Node.DOCUMENT_NODE) | 
| @@ -694,7 +800,7 @@ WebInspector.DOMNode.prototype = { | 
| /** | 
| * @param {boolean} optimized | 
| - * @return {WebInspector.DOMNode.XPathStep} | 
| + * @return {WebInspector.DOMNode.PathStep} | 
| */ | 
| _xPathValue: function(optimized) | 
| { | 
| @@ -706,7 +812,7 @@ WebInspector.DOMNode.prototype = { | 
| switch (this._nodeType) { | 
| case Node.ELEMENT_NODE: | 
| if (optimized && this.getAttribute("id")) | 
| - return new WebInspector.DOMNode.XPathStep("//*[@id=\"" + this.getAttribute("id") + "\"]", true); | 
| + return new WebInspector.DOMNode.PathStep("//*[@id=\"" + this.getAttribute("id") + "\"]", true); | 
| ownValue = this._localName; | 
| break; | 
| case Node.ATTRIBUTE_NODE: | 
| @@ -733,7 +839,7 @@ WebInspector.DOMNode.prototype = { | 
| if (ownIndex > 0) | 
| ownValue += "[" + ownIndex + "]"; | 
| - return new WebInspector.DOMNode.XPathStep(ownValue, this._nodeType === Node.DOCUMENT_NODE); | 
| + return new WebInspector.DOMNode.PathStep(ownValue, this._nodeType === Node.DOCUMENT_NODE); | 
| }, | 
| /** |