Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 752463002: Remove unused WebMIMERegistry (Closed)

Created:
6 years, 1 month ago by abarth-chromium
Modified:
6 years, 1 month ago
Reviewers:
esprehn, eseidel
CC:
esprehn, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -540 lines) Patch
M sky/engine/platform/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D sky/engine/platform/MIMETypeFromURL.h View 1 chunk +0 lines, -41 lines 0 comments Download
D sky/engine/platform/MIMETypeFromURL.cpp View 1 chunk +0 lines, -59 lines 0 comments Download
M sky/engine/platform/MIMETypeRegistry.h View 1 chunk +0 lines, -24 lines 0 comments Download
M sky/engine/platform/MIMETypeRegistry.cpp View 2 chunks +0 lines, -54 lines 0 comments Download
M sky/engine/platform/graphics/Image.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/platform/graphics/Image.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/public/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/public/platform/Platform.h View 2 chunks +0 lines, -4 lines 0 comments Download
D sky/engine/public/platform/WebMimeRegistry.h View 1 chunk +0 lines, -62 lines 0 comments Download
M sky/engine/testing/platform/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/testing/platform/platform_impl.h View 3 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/testing/platform/platform_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
D sky/engine/testing/platform/webmimeregistry_impl.h View 1 chunk +0 lines, -43 lines 0 comments Download
D sky/engine/testing/platform/webmimeregistry_impl.cc View 1 chunk +0 lines, -91 lines 0 comments Download
M sky/engine/web/FrameLoaderClientImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/viewer/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/viewer/platform/platform_impl.h View 3 chunks +0 lines, -3 lines 0 comments Download
M sky/viewer/platform/platform_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
D sky/viewer/platform/webmimeregistry_impl.h View 1 chunk +0 lines, -43 lines 0 comments Download
D sky/viewer/platform/webmimeregistry_impl.cc View 1 chunk +0 lines, -91 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
abarth-chromium
6 years, 1 month ago (2014-11-21 06:35:56 UTC) #1
esprehn
lgtm, wasn't this used for data urls once?
6 years, 1 month ago (2014-11-21 06:36:44 UTC) #3
eseidel
lgtm
6 years, 1 month ago (2014-11-21 06:36:57 UTC) #6
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
6 years, 1 month ago (2014-11-21 06:39:36 UTC) #8
abarth-chromium
On 2014/11/21 at 06:36:44, esprehn wrote: > lgtm, wasn't this used for data urls once? ...
6 years, 1 month ago (2014-11-21 06:40:13 UTC) #9
abarth-chromium
6 years, 1 month ago (2014-11-21 06:41:39 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
d19fb73ec996238b794f3864c3786d23fb2a3abe (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698