Issue 75243004: Replace character vectors with StringBuilders in the WebVTT tokenizer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 75243004: Replace character vectors with StringBuilders in the WebVTT tokenizer (Closed)

Created:
7 years, 1 month ago by fs

Modified:
7 years, 1 month ago

Reviewers:
Nate Chapin, jochen (gone - plz use gerrit)

CC:
blink-reviews, nessy, philipj_slow, gasubic, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Replace character vectors with StringBuilders in the WebVTT tokenizer With a goal of simplifying the state management of the WebVTTTokenizer/WebVTTToken pair, turn all character vectors into StringBuilders. Since the tokenizer in general deals with strings, this makes for a better fit in general (and at least two of the three eliminated FIXMEs should be able to attest to that). Also remove the local variable tagName in WebVTTTreeBuilder::constructTreeFromToken, which appear unused. BUG=319391 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162307

Patch Set 1 #

Patch Set 2 : Rebase after symbolnames changed #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -44 lines)			Patch
M	Source/core/html/track/vtt/VTTParser.cpp	View	1	4 chunks	+7 lines, -9 lines	0 comments	Download
M	Source/core/html/track/vtt/VTTToken.h	View	1	7 chunks	+12 lines, -11 lines	0 comments	Download
M	Source/core/html/track/vtt/VTTTokenizer.h	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	Source/core/html/track/vtt/VTTTokenizer.cpp	View	1	4 chunks	+14 lines, -23 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/75243004/40001

7 years, 1 month ago (2013-11-19 16:52:17 UTC) #5

Message was sent while issue was closed.

Change committed as 162307

Expand Messages | Collapse Messages