Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Side by Side Diff: tools/testing/dart/test_suite.dart

Issue 75243002: Removed assert for nonexistent use_browser_controller option (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Classes and methods for enumerating and preparing tests. 6 * Classes and methods for enumerating and preparing tests.
7 * 7 *
8 * This library includes: 8 * This library includes:
9 * 9 *
10 * - Creating tests by listing all the Dart files in certain directories, 10 * - Creating tests by listing all the Dart files in certain directories,
(...skipping 1095 matching lines...) Expand 10 before | Expand all | Expand 10 after
1106 dartFlags.add('--enable_asserts'); 1106 dartFlags.add('--enable_asserts');
1107 dartFlags.add("--enable_type_checks"); 1107 dartFlags.add("--enable_type_checks");
1108 } 1108 }
1109 dartFlags.addAll(vmOptions); 1109 dartFlags.addAll(vmOptions);
1110 } 1110 }
1111 1111
1112 commandSet.add(CommandBuilder.instance.getContentShellCommand( 1112 commandSet.add(CommandBuilder.instance.getContentShellCommand(
1113 contentShellFilename, fullHtmlPath, contentShellOptions, 1113 contentShellFilename, fullHtmlPath, contentShellOptions,
1114 dartFlags, configurationDir)); 1114 dartFlags, configurationDir));
1115 } else { 1115 } else {
1116 assert(configuration['use_browser_controller']);
1117 // This command is not actually run, it is used for reproducing 1116 // This command is not actually run, it is used for reproducing
1118 // the failure. 1117 // the failure.
1119 args = ['tools/testing/dart/launch_browser.dart', 1118 args = ['tools/testing/dart/launch_browser.dart',
1120 runtime, 1119 runtime,
1121 fullHtmlPath]; 1120 fullHtmlPath];
1122 commandSet.add(CommandBuilder.instance.getBrowserTestCommand( 1121 commandSet.add(CommandBuilder.instance.getBrowserTestCommand(
1123 runtime, fullHtmlPath, TestUtils.dartTestExecutable.toString(), 1122 runtime, fullHtmlPath, TestUtils.dartTestExecutable.toString(),
1124 args, configurationDir, checkedMode: configuration['checked'])); 1123 args, configurationDir, checkedMode: configuration['checked']));
1125 } 1124 }
1126 1125
(...skipping 918 matching lines...) Expand 10 before | Expand all | Expand 10 after
2045 * $pass tests are expected to pass 2044 * $pass tests are expected to pass
2046 * $failOk tests are expected to fail that we won't fix 2045 * $failOk tests are expected to fail that we won't fix
2047 * $fail tests are expected to fail that we should fix 2046 * $fail tests are expected to fail that we should fix
2048 * $crash tests are expected to crash that we should fix 2047 * $crash tests are expected to crash that we should fix
2049 * $timeout tests are allowed to timeout 2048 * $timeout tests are allowed to timeout
2050 * $compileErrorSkip tests are skipped on browsers due to compile-time error 2049 * $compileErrorSkip tests are skipped on browsers due to compile-time error
2051 """; 2050 """;
2052 print(report); 2051 print(report);
2053 } 2052 }
2054 } 2053 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698