Issue 7524020: Make the headers for protocol handler settings the same size as other headers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7524020: Make the headers for protocol handler settings the same size as other headers. (Closed)

Created:
9 years, 4 months ago by koz (OOO until 15th September)

Modified:
9 years, 4 months ago

Reviewers:
csilv, commit-bot: I haz the power, James Hawkins

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Make the headers for protocol handler settings the same size as other headers. TEST=tested visually Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95021

Patch Set 1 #

Patch Set 2 : asdf #

Patch Set 3 : rebase #

Total comments: 1

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	chrome/browser/resources/options/handler_options.css	View		2 chunks	+2 lines, -1 line	0 comments	Download
	M	chrome/browser/resources/options/handler_options.html	View	1	1 chunk	+2 lines, -2 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

koz (OOO until 15th September)

As discussed in codereview.chromium.org/7495011.

9 years, 4 months ago (2011-07-28 03:51:47 UTC) #1

James Hawkins

9 years, 4 months ago (2011-08-02 01:29:31 UTC) #4

http://codereview.chromium.org/7524020/diff/5001/chrome/browser/resources/opt...
File chrome/browser/resources/options/handler_options.html (right):

http://codereview.chromium.org/7524020/diff/5001/chrome/browser/resources/opt...
chrome/browser/resources/options/handler_options.html:6: <div
i18n-content="handlers_type_column_header"></div>
If these really are headers, then they should remain hX with the proper styling
you're looking for in the CSS.

Expand Messages | Collapse Messages