tools/telemetry/telemetry/unittest_util/run_tests.py - Issue 752393005: [Telemetry] Reland increased unittest parallelism everywhere except XP.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/unittest_util/run_tests.py

Issue 752393005: [Telemetry] Reland increased unittest parallelism everywhere except XP. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/unittest_util/run_tests.py

diff --git a/tools/telemetry/telemetry/unittest_util/run_tests.py b/tools/telemetry/telemetry/unittest_util/run_tests.py

index 2f727cf5d815aa735a4db1b570677da9fa7f1f17..0f3343aa83200dbd239bcf08513dfde08ac89e8a 100644

--- a/tools/telemetry/telemetry/unittest_util/run_tests.py

+++ b/tools/telemetry/telemetry/unittest_util/run_tests.py

@@ -101,8 +101,12 @@ class RunTestsCommand(command_line.OptparseCommand):

# on Android and ChromeOS.

if possible_browser.platform.GetOSName() in ('android', 'chromeos'):

runner.args.jobs = 1

- else:

+ elif possible_browser.platform.GetOSVersionName() == 'xp':

+ # For an undiagnosed reason, XP falls over with more parallelism.

+ # See crbug.com/388256

runner.args.jobs = max(int(args.jobs) // 4, 1)

+ else:

+ runner.args.jobs = max(int(args.jobs) // 2, 1)

runner.args.metadata = args.metadata

runner.args.passthrough = args.passthrough

« no previous file with comments | « no previous file | no next file » | no next file with comments »