Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Issue 752373003: Remove duplicated code for image-strip computation in InlineFlowBoxPainter (Closed)

Created:
6 years ago by fs
Modified:
6 years ago
CC:
blink-reviews, blink-reviews-paint_chromium.org, slimming-paint-reviews_chromium.org
Project:
blink
Visibility:
Public.

Description

Remove duplicated code for image-strip computation in InlineFlowBoxPainter The code to compute the "strip"/"slice" of an inline was duplicated for the border, mask and fill cases. Move this code to a new method paintRectForImageStrip. BUG=423071 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186531

Patch Set 1 #

Total comments: 9

Patch Set 2 : Explicit direction; Restore FIXME. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -57 lines) Patch
M Source/core/paint/InlineFlowBoxPainter.h View 1 3 chunks +3 lines, -0 lines 0 comments Download
M Source/core/paint/InlineFlowBoxPainter.cpp View 1 4 chunks +41 lines, -57 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
fs
6 years ago (2014-12-04 14:00:11 UTC) #2
chrishtr
https://codereview.chromium.org/752373003/diff/1/Source/core/paint/InlineFlowBoxPainter.cpp File Source/core/paint/InlineFlowBoxPainter.cpp (left): https://codereview.chromium.org/752373003/diff/1/Source/core/paint/InlineFlowBoxPainter.cpp#oldcode236 Source/core/paint/InlineFlowBoxPainter.cpp:236: // FIXME: What the heck do we do with ...
6 years ago (2014-12-04 17:25:04 UTC) #3
fs
https://codereview.chromium.org/752373003/diff/1/Source/core/paint/InlineFlowBoxPainter.cpp File Source/core/paint/InlineFlowBoxPainter.cpp (left): https://codereview.chromium.org/752373003/diff/1/Source/core/paint/InlineFlowBoxPainter.cpp#oldcode236 Source/core/paint/InlineFlowBoxPainter.cpp:236: // FIXME: What the heck do we do with ...
6 years ago (2014-12-04 17:42:03 UTC) #4
chrishtr
https://codereview.chromium.org/752373003/diff/1/Source/core/paint/InlineFlowBoxPainter.cpp File Source/core/paint/InlineFlowBoxPainter.cpp (left): https://codereview.chromium.org/752373003/diff/1/Source/core/paint/InlineFlowBoxPainter.cpp#oldcode236 Source/core/paint/InlineFlowBoxPainter.cpp:236: // FIXME: What the heck do we do with ...
6 years ago (2014-12-04 17:47:57 UTC) #5
fs
https://codereview.chromium.org/752373003/diff/1/Source/core/paint/InlineFlowBoxPainter.cpp File Source/core/paint/InlineFlowBoxPainter.cpp (left): https://codereview.chromium.org/752373003/diff/1/Source/core/paint/InlineFlowBoxPainter.cpp#oldcode236 Source/core/paint/InlineFlowBoxPainter.cpp:236: // FIXME: What the heck do we do with ...
6 years ago (2014-12-04 18:15:46 UTC) #6
chrishtr
lgtm
6 years ago (2014-12-04 18:21:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/752373003/20001
6 years ago (2014-12-04 18:21:23 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-04 19:09:55 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186531

Powered by Google App Engine
This is Rietveld 408576698