Issue 75233002: Don't find(':') twice in WebVTTParser::collectMetadataHeader

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 75233002: Don't find(':') twice in WebVTTParser::collectMetadataHeader (Closed)

Created:
7 years, 1 month ago by fs

Modified:
7 years, 1 month ago

Reviewers:
Nate Chapin, jochen (gone - plz use gerrit)

CC:
blink-reviews, nessy, philipj_slow, gasubic, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Don't find(':') twice in WebVTTParser::collectMetadataHeader Since contains(':') is the equivalent of a find(':') - except it throws away the result - and the result might be of interest later on, just call find(':') once instead, and remove the call to contains(...) (essentially open-coding it.) BUG=305317 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162202

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	Source/core/html/track/vtt/VTTParser.cpp	View		1 chunk	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/75233002/1

7 years, 1 month ago (2013-11-18 13:09:51 UTC) #3

Message was sent while issue was closed.

Change committed as 162202

Expand Messages | Collapse Messages