Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 752263002: make SkRefCnt::getRefCnt() debug-only, remove it from SkNVRefCnt. (Closed)

Created:
6 years ago by mtklein_C
Modified:
6 years ago
Reviewers:
f(malita), mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

make SkRefCnt::getRefCnt() debug-only, remove it from SkNVRefCnt. Only (unused) API removed. TBR=reed@google.com BUG=skia:3160 Committed: https://skia.googlesource.com/skia/+/bbb61d7268b26d240afde2c924cb7d1370aa4071

Patch Set 1 #

Patch Set 2 : typos #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -51 lines) Patch
M include/core/SkRefCnt.h View 2 chunks +2 lines, -1 line 0 comments Download
M tests/MetaDataTest.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M tests/RefCntTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/RefDictTest.cpp View 1 1 chunk +15 lines, -15 lines 0 comments Download
M tests/SurfaceTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/UtilsTest.cpp View 1 4 chunks +25 lines, -25 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
mtklein_C
6 years ago (2014-11-24 20:55:42 UTC) #2
f(malita)
lgtm
6 years ago (2014-11-24 20:57:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/752263002/20001
6 years ago (2014-11-24 20:58:34 UTC) #5
commit-bot: I haz the power
6 years ago (2014-11-24 21:09:43 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/bbb61d7268b26d240afde2c924cb7d1370aa4071

Powered by Google App Engine
This is Rietveld 408576698