Add an Android-framework-only stable ID to SkPixelRef.

Add an Android-framework-only stable ID to SkPixelRef.

BUG:b/18245805

Committed: https://skia.googlesource.com/skia/+/f3ca41c723f3a33a766de64a1cda9a01bab20142

[scroggo, 2014-11-24 19:11:08]

scroggo@google.com changed reviewers:
+ djsollen@google.com, reed@google.com

[mtklein, 2014-11-24 19:12:40]

mtklein@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2014-11-24 19:12:41]

https://codereview.chromium.org/752203002/diff/1/include/core/SkPixelRef.h
File include/core/SkPixelRef.h (right):

https://codereview.chromium.org/752203002/diff/1/include/core/SkPixelRef.h#ne...
include/core/SkPixelRef.h:373: mutable SkTRacy<uint32_t> fStableID;
const uint32_t and fill it in the constructor?  It's not going to change...

[scroggo, 2014-11-24 19:20:25]

https://codereview.chromium.org/752203002/diff/1/include/core/SkPixelRef.h
File include/core/SkPixelRef.h (right):

https://codereview.chromium.org/752203002/diff/1/include/core/SkPixelRef.h#ne...
include/core/SkPixelRef.h:373: mutable SkTRacy<uint32_t> fStableID;
On 2014/11/24 19:12:41, mtklein wrote:
> const uint32_t and fill it in the constructor?  It's not going to change...

Done.

[mtklein, 2014-11-24 19:34:03]

lgtm

[scroggo, 2014-11-25 15:53:17]

reed@, can I get an API review?

[scroggo, 2014-11-25 15:53:21]

The CQ bit was checked by scroggo@google.com

[reed1, 2014-11-25 15:54:07]

https://codereview.chromium.org/752203002/diff/20001/include/core/SkPixelRef.h
File include/core/SkPixelRef.h (right):

https://codereview.chromium.org/752203002/diff/20001/include/core/SkPixelRef....
include/core/SkPixelRef.h:138: uint32_t getStableID() const { return fStableID;
}
bikeshed: getStructureID or some name that refers to the part that is being ID'd
?

[commit-bot: I haz the power, 2014-11-25 15:54:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/752203002/20001

[commit-bot: I haz the power, 2014-11-25 15:54:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-25 15:54:33]

Presubmit check for 752203002-20001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Since the CL is editing public API, you must have an LGTM from one of:
('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org',
'bsalomon@google.com', 'djsollen@chromium.org', 'djsollen@google.com')

Was the presubmit check useful? If not, run "git cl presubmit -v"
to figure out which PRESUBMIT.py was run, then run git blame
on the file to figure out who to ask for help.

[reed1, 2014-11-25 15:58:54]

Perhaps a note somewhere about how this is used... dunno.

lgtm

[scroggo, 2014-11-25 16:48:19]

On 2014/11/25 15:58:54, reed1 wrote:
> Perhaps a note somewhere about how this is used... dunno.

From the original patch:

"Can be used as a key which must remain unique across changes and
deletions."

Is that not descriptive enough? To me it seems strange go into more detail about
Android's caching system, since that is external, and doesn't give any more
information about what this call does.

That said, I've updated the comment to perhaps be a little more clear. Let me
know what you think.

[reed1, 2014-11-25 17:13:51]

On 2014/11/25 16:48:19, scroggo wrote:
> On 2014/11/25 15:58:54, reed1 wrote:
> > Perhaps a note somewhere about how this is used... dunno.
> 
> From the original patch:
> 
> "Can be used as a key which must remain unique across changes and
> deletions."
> 
> Is that not descriptive enough? To me it seems strange go into more detail
about
> Android's caching system, since that is external, and doesn't give any more
> information about what this call does.
> 
> That said, I've updated the comment to perhaps be a little more clear. Let me
> know what you think.

I'm fine w/ no additional comments.

[scroggo, 2014-11-25 21:30:40]

The CQ bit was checked by scroggo@google.com

[commit-bot: I haz the power, 2014-11-25 21:30:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/752203002/40001

[commit-bot: I haz the power, 2014-11-25 21:42:18]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/f3ca41c723f3a33a766de64a1cda9a01bab20142