Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 752183002: Use text size on Mac. (Closed)

Created:
6 years ago by bungeman-skia
Modified:
6 years ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Use text size on Mac. The current code assumes that text on Mac is freely scalable, or at least that the text size is just a part of the transform. However, it appears that application of the 'trak' table, as well as other optical adjustments, may rely on the text size directly. This change passes the text size requested directly to CoreText. BUG=chromium:427528 Committed: https://skia.googlesource.com/skia/+/be2284de556e7ec29489693093d42dc86b762645

Patch Set 1 #

Patch Set 2 : Clean up a bit. #

Patch Set 3 : Try to fix zero. #

Total comments: 4

Patch Set 4 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -6 lines) Patch
M src/core/SkScalerContext.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/SkScalerContext.cpp View 1 2 3 2 chunks +13 lines, -0 lines 0 comments Download
M src/ports/SkFontHost_mac.cpp View 1 2 3 3 chunks +19 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
bungeman-skia
Currently testing to see what this might do to the Blink layout tests at https://codereview.chromium.org/756743004 ...
6 years ago (2014-11-24 22:45:48 UTC) #2
bungeman-skia
On 2014/11/24 22:45:48, bungeman1 wrote: > Currently testing to see what this might do to ...
6 years ago (2014-11-25 02:14:57 UTC) #3
reed1
lgtm w/ request for slight refactorying/comments now or in a follow-up CL. https://codereview.chromium.org/752183002/diff/40001/src/ports/SkFontHost_mac.cpp File src/ports/SkFontHost_mac.cpp ...
6 years ago (2014-11-25 14:31:35 UTC) #4
bungeman-skia
How about like this? https://codereview.chromium.org/752183002/diff/40001/src/ports/SkFontHost_mac.cpp File src/ports/SkFontHost_mac.cpp (right): https://codereview.chromium.org/752183002/diff/40001/src/ports/SkFontHost_mac.cpp#newcode720 src/ports/SkFontHost_mac.cpp:720: SkMatrix skTransform; On 2014/11/25 14:31:35, ...
6 years ago (2014-11-25 15:36:11 UTC) #5
reed1
purty lgtm
6 years ago (2014-11-25 15:41:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/752183002/60001
6 years ago (2014-11-25 15:57:28 UTC) #8
commit-bot: I haz the power
6 years ago (2014-11-25 16:08:12 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/be2284de556e7ec29489693093d42dc86b762645

Powered by Google App Engine
This is Rietveld 408576698