Issue 752153002: Sync XMLSerializer IDL with spec

Issue 752153002: Sync XMLSerializer IDL with spec (Closed)

Created:
6 years ago by philipj_slow

Modified:
6 years ago

Reviewers:
sof

CC:
blink-reviews, arv+blink, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Sync XMLSerializer IDL with spec https://dvcs.w3.org/hg/innerhtml/raw-file/tip/index.html#the-xmlserializer-interface R=sigbjornf@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185947

Patch Set 3 : test no arguments #

Patch Set 4 : rebase #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -35 lines)			Patch
M	LayoutTests/fast/dom/xmlserializer-serialize-to-string-exception.html	View	1 2	4 chunks	+5 lines, -4 lines	0 comments	Download
M	LayoutTests/fast/dom/xmlserializer-serialize-to-string-exception-expected.txt	View	1 2	1 chunk	+22 lines, -18 lines	0 comments	Download
M	Source/core/xml/XMLSerializer.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/xml/XMLSerializer.cpp	View		1 chunk	+3 lines, -9 lines	0 comments	Download
M	Source/core/xml/XMLSerializer.idl	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 17 (5 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

philipj_slow

PTAL. No observable change beyond the exception message intended.

6 years ago (2014-11-25 08:32:57 UTC) #3

philipj_slow

On 2014/11/25 10:59:03, sof wrote: > While we're here..could you add a test for the ...

6 years ago (2014-11-25 11:58:59 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/752153002/40001

6 years ago (2014-11-25 12:20:13 UTC) #9

commit-bot: I haz the power

Failed to apply patch for LayoutTests/fast/dom/xmlserializer-serialize-to-string-exception-expected.txt: While running svn add LayoutTests/fast --force --config-dir /b/infra_internal/commit_queue/subversion_config --non-interactive; ...

6 years ago (2014-11-25 12:33:51 UTC) #11

Failed to apply patch for
LayoutTests/fast/dom/xmlserializer-serialize-to-string-exception-expected.txt:
While running svn add LayoutTests/fast --force --config-dir
/b/infra_internal/commit_queue/subversion_config --non-interactive;
  svn: Directory 'LayoutTests/fast/.svn' containing working copy admin area is
missing

Patch:      
LayoutTests/fast/dom/xmlserializer-serialize-to-string-exception-expected.txt
Index:
LayoutTests/fast/dom/xmlserializer-serialize-to-string-exception-expected.txt
diff --git
a/LayoutTests/fast/dom/xmlserializer-serialize-to-string-exception-expected.txt
b/LayoutTests/fast/dom/xmlserializer-serialize-to-string-exception-expected.txt
index
c809966e4cefaa9dfb8de60c5eda1d779bc8548d..3ceb7e36f62d1d4fdb57d389979a415198b98a9d
100644
---
a/LayoutTests/fast/dom/xmlserializer-serialize-to-string-exception-expected.txt
+++
b/LayoutTests/fast/dom/xmlserializer-serialize-to-string-exception-expected.txt
@@ -1,47 +1,51 @@
 This tests XMLSerializer.serializeToString() throwing exception when node value
is invalid and passing otherwise.
 
-1. Verifying XMLSerializer.serializeToString() should THROW exception with node
value = null
-Exception thrown = [TypeError: Failed to execute 'serializeToString' on
'XMLSerializer': Invalid node value.]
+1. Verifying XMLSerializer.serializeToString() should THROW exception with no
argument
+Exception thrown = [TypeError: Failed to execute 'serializeToString' on
'XMLSerializer': 1 argument required, but only 0 present.]
 PASS
 
-2. Verifying XMLSerializer.serializeToString() should THROW exception with node
value = undefined
-Exception thrown = [TypeError: Failed to execute 'serializeToString' on
'XMLSerializer': Invalid node value.]
+2. Verifying XMLSerializer.serializeToString() should THROW exception with
argument null
+Exception thrown = [TypeError: Failed to execute 'serializeToString' on
'XMLSerializer': parameter 1 is not of type 'Node'.]
 PASS
 
-3. Verifying XMLSerializer.serializeToString() should THROW exception with node
value = <html><title>Hello World</title></html>
-Exception thrown = [TypeError: Failed to execute 'serializeToString' on
'XMLSerializer': Invalid node value.]
+3. Verifying XMLSerializer.serializeToString() should THROW exception with
argument undefined
+Exception thrown = [TypeError: Failed to execute 'serializeToString' on
'XMLSerializer': parameter 1 is not of type 'Node'.]
 PASS
 
-4. Verifying XMLSerializer.serializeToString() should THROW exception with node
value = [object HTMLCollection]
-Exception thrown = [TypeError: Failed to execute 'serializeToString' on
'XMLSerializer': Invalid node value.]
+4. Verifying XMLSerializer.serializeToString() should THROW exception with
argument <html><title>Hello World</title></html>
+Exception thrown = [TypeError: Failed to execute 'serializeToString' on
'XMLSerializer': parameter 1 is not of type 'Node'.]
 PASS
 
-5. Verifying XMLSerializer.serializeToString() should NOT-THROW exception with
node value = [object HTMLDocument]
+5. Verifying XMLSerializer.serializeToString() should THROW exception with
argument [object HTMLCollection]
+Exception thrown = [TypeError: Failed to execute 'serializeToString' on
'XMLSerializer': parameter 1 is not of type 'Node'.]
 PASS
 
-6. Verifying XMLSerializer.serializeToString() should NOT-THROW exception with
node value = [object HTMLHtmlElement]
+6. Verifying XMLSerializer.serializeToString() should NOT-THROW exception with
argument [object HTMLDocument]
 PASS
 
-7. Verifying XMLSerializer.serializeToString() should NOT-THROW exception with
node value = [object HTMLHtmlElement]
+7. Verifying XMLSerializer.serializeToString() should NOT-THROW exception with
argument [object HTMLHtmlElement]
 PASS
 
-8. Verifying XMLSerializer.serializeToString() should NOT-THROW exception with
node value = [object HTMLDivElement]
+8. Verifying XMLSerializer.serializeToString() should NOT-THROW exception with
argument [object HTMLHtmlElement]
 PASS
 
-9. Verifying XMLSerializer.serializeToString() should NOT-THROW exception with
node value = [object HTMLHeadingElement]
+9. Verifying XMLSerializer.serializeToString() should NOT-THROW exception with
argument [object HTMLDivElement]
 PASS
 
-10. Verifying XMLSerializer.serializeToString() should NOT-THROW exception with
node value = [object HTMLUnknownElement]
+10. Verifying XMLSerializer.serializeToString() should NOT-THROW exception with
argument [object HTMLHeadingElement]
 PASS
 
-11. Verifying XMLSerializer.serializeToString() should NOT-THROW exception with
node value = [object HTMLDocument]
+11. Verifying XMLSerializer.serializeToString() should NOT-THROW exception with
argument [object HTMLUnknownElement]
 PASS
 
-12. Verifying XMLSerializer.serializeToString() should NOT-THROW exception with
node value = [object HTMLHtmlElement]
+12. Verifying XMLSerializer.serializeToString() should NOT-THROW exception with
argument [object HTMLDocument]
 PASS
 
-13. Verifying XMLSerializer.serializeToString() should NOT-THROW exception with
node value = [object XMLDocument]
+13. Verifying XMLSerializer.serializeToString() should NOT-THROW exception with
argument [object HTMLHtmlElement]
 PASS
 
-14. Verifying XMLSerializer.serializeToString() should NOT-THROW exception with
node value = [object Element]
+14. Verifying XMLSerializer.serializeToString() should NOT-THROW exception with
argument [object XMLDocument]
+PASS
+
+15. Verifying XMLSerializer.serializeToString() should NOT-THROW exception with
argument [object Element]
 PASS

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/752153002/40001

6 years ago (2014-11-25 13:05:51 UTC) #13

commit-bot: I haz the power

Failed to apply patch for LayoutTests/fast/dom/xmlserializer-serialize-to-string-exception-expected.txt: While running patch -p1 --forward --force --no-backup-if-mismatch; can't find ...

6 years ago (2014-11-25 13:09:34 UTC) #15

Failed to apply patch for
LayoutTests/fast/dom/xmlserializer-serialize-to-string-exception-expected.txt:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  can't find file to patch at input line 6
  Perhaps you used the wrong -p or --strip option?
  The text leading up to this was:
  --------------------------
  |Index:
LayoutTests/fast/dom/xmlserializer-serialize-to-string-exception-expected.txt
  |diff --git
a/LayoutTests/fast/dom/xmlserializer-serialize-to-string-exception-expected.txt
b/LayoutTests/fast/dom/xmlserializer-serialize-to-string-exception-expected.txt
  |index
c809966e4cefaa9dfb8de60c5eda1d779bc8548d..3ceb7e36f62d1d4fdb57d389979a415198b98a9d
100644
  |---
a/LayoutTests/fast/dom/xmlserializer-serialize-to-string-exception-expected.txt
  |+++
b/LayoutTests/fast/dom/xmlserializer-serialize-to-string-exception-expected.txt
  --------------------------
  No file to patch.  Skipping patch.
  1 out of 1 hunk ignored

Patch:      
LayoutTests/fast/dom/xmlserializer-serialize-to-string-exception-expected.txt
Index:
LayoutTests/fast/dom/xmlserializer-serialize-to-string-exception-expected.txt
diff --git
a/LayoutTests/fast/dom/xmlserializer-serialize-to-string-exception-expected.txt
b/LayoutTests/fast/dom/xmlserializer-serialize-to-string-exception-expected.txt
index
c809966e4cefaa9dfb8de60c5eda1d779bc8548d..3ceb7e36f62d1d4fdb57d389979a415198b98a9d
100644
---
a/LayoutTests/fast/dom/xmlserializer-serialize-to-string-exception-expected.txt
+++
b/LayoutTests/fast/dom/xmlserializer-serialize-to-string-exception-expected.txt
@@ -1,47 +1,51 @@
 This tests XMLSerializer.serializeToString() throwing exception when node value
is invalid and passing otherwise.
 
-1. Verifying XMLSerializer.serializeToString() should THROW exception with node
value = null
-Exception thrown = [TypeError: Failed to execute 'serializeToString' on
'XMLSerializer': Invalid node value.]
+1. Verifying XMLSerializer.serializeToString() should THROW exception with no
argument
+Exception thrown = [TypeError: Failed to execute 'serializeToString' on
'XMLSerializer': 1 argument required, but only 0 present.]
 PASS
 
-2. Verifying XMLSerializer.serializeToString() should THROW exception with node
value = undefined
-Exception thrown = [TypeError: Failed to execute 'serializeToString' on
'XMLSerializer': Invalid node value.]
+2. Verifying XMLSerializer.serializeToString() should THROW exception with
argument null
+Exception thrown = [TypeError: Failed to execute 'serializeToString' on
'XMLSerializer': parameter 1 is not of type 'Node'.]
 PASS
 
-3. Verifying XMLSerializer.serializeToString() should THROW exception with node
value = <html><title>Hello World</title></html>
-Exception thrown = [TypeError: Failed to execute 'serializeToString' on
'XMLSerializer': Invalid node value.]
+3. Verifying XMLSerializer.serializeToString() should THROW exception with
argument undefined
+Exception thrown = [TypeError: Failed to execute 'serializeToString' on
'XMLSerializer': parameter 1 is not of type 'Node'.]
 PASS
 
-4. Verifying XMLSerializer.serializeToString() should THROW exception with node
value = [object HTMLCollection]
-Exception thrown = [TypeError: Failed to execute 'serializeToString' on
'XMLSerializer': Invalid node value.]
+4. Verifying XMLSerializer.serializeToString() should THROW exception with
argument <html><title>Hello World</title></html>
+Exception thrown = [TypeError: Failed to execute 'serializeToString' on
'XMLSerializer': parameter 1 is not of type 'Node'.]
 PASS
 
-5. Verifying XMLSerializer.serializeToString() should NOT-THROW exception with
node value = [object HTMLDocument]
+5. Verifying XMLSerializer.serializeToString() should THROW exception with
argument [object HTMLCollection]
+Exception thrown = [TypeError: Failed to execute 'serializeToString' on
'XMLSerializer': parameter 1 is not of type 'Node'.]
 PASS
 
-6. Verifying XMLSerializer.serializeToString() should NOT-THROW exception with
node value = [object HTMLHtmlElement]
+6. Verifying XMLSerializer.serializeToString() should NOT-THROW exception with
argument [object HTMLDocument]
 PASS
 
-7. Verifying XMLSerializer.serializeToString() should NOT-THROW exception with
node value = [object HTMLHtmlElement]
+7. Verifying XMLSerializer.serializeToString() should NOT-THROW exception with
argument [object HTMLHtmlElement]
 PASS
 
-8. Verifying XMLSerializer.serializeToString() should NOT-THROW exception with
node value = [object HTMLDivElement]
+8. Verifying XMLSerializer.serializeToString() should NOT-THROW exception with
argument [object HTMLHtmlElement]
 PASS
 
-9. Verifying XMLSerializer.serializeToString() should NOT-THROW exception with
node value = [object HTMLHeadingElement]
+9. Verifying XMLSerializer.serializeToString() should NOT-THROW exception with
argument [object HTMLDivElement]
 PASS
 
-10. Verifying XMLSerializer.serializeToString() should NOT-THROW exception with
node value = [object HTMLUnknownElement]
+10. Verifying XMLSerializer.serializeToString() should NOT-THROW exception with
argument [object HTMLHeadingElement]
 PASS
 
-11. Verifying XMLSerializer.serializeToString() should NOT-THROW exception with
node value = [object HTMLDocument]
+11. Verifying XMLSerializer.serializeToString() should NOT-THROW exception with
argument [object HTMLUnknownElement]
 PASS
 
-12. Verifying XMLSerializer.serializeToString() should NOT-THROW exception with
node value = [object HTMLHtmlElement]
+12. Verifying XMLSerializer.serializeToString() should NOT-THROW exception with
argument [object HTMLDocument]
 PASS
 
-13. Verifying XMLSerializer.serializeToString() should NOT-THROW exception with
node value = [object XMLDocument]
+13. Verifying XMLSerializer.serializeToString() should NOT-THROW exception with
argument [object HTMLHtmlElement]
 PASS
 
-14. Verifying XMLSerializer.serializeToString() should NOT-THROW exception with
node value = [object Element]
+14. Verifying XMLSerializer.serializeToString() should NOT-THROW exception with
argument [object XMLDocument]
+PASS
+
+15. Verifying XMLSerializer.serializeToString() should NOT-THROW exception with
argument [object Element]
 PASS

philipj_slow

6 years ago (2014-11-25 13:53:20 UTC) #17

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as 185947 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages