Issue 752093003: Specs: clean up event listeners a bit. Drop the pointless

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 752093003: Specs: clean up event listeners a bit. Drop the pointless (Closed)

Created:
6 years ago by Hixie

Modified:
6 years ago

Reviewers:

CC:
mojo-reviews_chromium.org, ojan, esprehn, abarth-chromium

Base URL:
https://github.com/domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Specs: clean up event listeners a bit. Drop the pointless 'preventDefault()', since that doesn't really do anything now. Clean up how dispatchEvent() works. Add a 'handled' boolean that listeners can check to see if they should ignore the event. Committed: https://chromium.googlesource.com/external/mojo/+/7958a69bd8b9ce2c3cea30dd7807ce53946d1c66

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -5 lines)			Patch
	M	sky/specs/apis.md	View		1 chunk	+12 lines, -5 lines	0 comments	Download

Total messages: 1 (0 generated)

Hixie

6 years ago (2014-11-24 21:55:43 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7958a69bd8b9ce2c3cea30dd7807ce53946d1c66.