Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 752083003: Use IDL union types for CanvasRenderingContext2D.{fill,stroke}Style (Closed)

Created:
6 years ago by fs
Modified:
6 years ago
CC:
blink-reviews, arv+blink, blink-reviews-html_chromium.org, dglazkov+blink, Rik, blink-reviews-bindings_chromium.org, Inactive, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Use IDL union types for CanvasRenderingContext2D.{fill,stroke}Style This gets rid of the custom bindings for said attributes by using the union type support in the bindings codegen. Also rework the resolution of 'currentColor' by using parseColorOrCurrentColor directly in set{Fill,Stroke}Style, rather than first parse and then resolve. This allows CanvasStyle to cleaned up and shrunk a bit. Also remove code from CanvasStyle that became dead when the legacy set{Fill,Stroke}Color methods was removed (CMYKA, float RGBA, gray-level, override alpha). BUG=430337 BUG=363180, 363181 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185879

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -312 lines) Patch
D Source/bindings/core/v8/custom/V8CanvasRenderingContext2DCustom.cpp View 1 chunk +0 lines, -102 lines 0 comments Download
M Source/bindings/core/v8/custom/custom.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.cpp View 1 chunk +73 lines, -34 lines 2 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.idl View 1 chunk +2 lines, -3 lines 3 comments Download
M Source/core/html/canvas/CanvasStyle.h View 1 chunk +4 lines, -34 lines 1 comment Download
M Source/core/html/canvas/CanvasStyle.cpp View 4 chunks +6 lines, -134 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
fs
https://codereview.chromium.org/752083003/diff/1/Source/core/html/canvas/CanvasRenderingContext2D.cpp File Source/core/html/canvas/CanvasRenderingContext2D.cpp (right): https://codereview.chromium.org/752083003/diff/1/Source/core/html/canvas/CanvasRenderingContext2D.cpp#newcode463 Source/core/html/canvas/CanvasRenderingContext2D.cpp:463: if (colorString == state().m_unparsedStrokeColor) The removal of the legacy ...
6 years ago (2014-11-24 13:20:25 UTC) #2
Jens Widell
Union type usage LGTM, and custom bindings removal LGTM++. https://codereview.chromium.org/752083003/diff/1/Source/core/html/canvas/CanvasRenderingContext2D.idl File Source/core/html/canvas/CanvasRenderingContext2D.idl (left): https://codereview.chromium.org/752083003/diff/1/Source/core/html/canvas/CanvasRenderingContext2D.idl#oldcode66 Source/core/html/canvas/CanvasRenderingContext2D.idl:66: ...
6 years ago (2014-11-24 13:38:24 UTC) #3
fs
https://codereview.chromium.org/752083003/diff/1/Source/core/html/canvas/CanvasRenderingContext2D.idl File Source/core/html/canvas/CanvasRenderingContext2D.idl (left): https://codereview.chromium.org/752083003/diff/1/Source/core/html/canvas/CanvasRenderingContext2D.idl#oldcode66 Source/core/html/canvas/CanvasRenderingContext2D.idl:66: // FIXME: Use union types when supported: http://crbug.com/372891 On ...
6 years ago (2014-11-24 13:49:07 UTC) #4
haraken
LGTM
6 years ago (2014-11-24 14:47:23 UTC) #6
Justin Novosad
lgtm https://codereview.chromium.org/752083003/diff/1/Source/core/html/canvas/CanvasRenderingContext2D.cpp File Source/core/html/canvas/CanvasRenderingContext2D.cpp (right): https://codereview.chromium.org/752083003/diff/1/Source/core/html/canvas/CanvasRenderingContext2D.cpp#newcode463 Source/core/html/canvas/CanvasRenderingContext2D.cpp:463: if (colorString == state().m_unparsedStrokeColor) On 2014/11/24 13:20:24, fs ...
6 years ago (2014-11-24 15:41:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/752083003/1
6 years ago (2014-11-24 16:00:43 UTC) #9
commit-bot: I haz the power
6 years ago (2014-11-24 16:07:08 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185879

Powered by Google App Engine
This is Rietveld 408576698