Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 752073002: Enabling test for a-name.html (Closed)

Created:
6 years ago by shreeramk
Modified:
6 years ago
Reviewers:
dmazzoni
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Enabling test for a-name.html Named anchors <a name> are exposed correctly via MSAA, hence removing 'skip' BUG=120946 Committed: https://crrev.com/55d2935d5d63ddde0b84af7bfe92f7faccfaa986 Cr-Commit-Position: refs/heads/master@{#305454}

Patch Set 1 #

Patch Set 2 : updating expectations for mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M content/test/data/accessibility/a-name-expected-mac.txt View 1 1 chunk +5 lines, -1 line 0 comments Download
M content/test/data/accessibility/a-name-expected-win.txt View 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
shreeramk
Please review. Thanks!!!
6 years ago (2014-11-24 10:23:25 UTC) #2
dmazzoni
lgtm
6 years ago (2014-11-24 17:39:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/752073002/20001
6 years ago (2014-11-24 17:40:29 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-11-24 18:48:17 UTC) #6
commit-bot: I haz the power
6 years ago (2014-11-24 18:49:10 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/55d2935d5d63ddde0b84af7bfe92f7faccfaa986
Cr-Commit-Position: refs/heads/master@{#305454}

Powered by Google App Engine
This is Rietveld 408576698