Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(930)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 752063002: Move C++ flags for Android to cxxflags section (Closed)

Created:
6 years ago by jochen (gone - plz use gerrit)
Modified:
6 years ago
Reviewers:
ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Move C++ flags for Android to cxxflags section BUG=v8:3693 R=ulan@chromium.org LOG=n

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M build/android.gypi View 1 2 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
jochen (gone - plz use gerrit)
6 years ago (2014-11-24 08:23:25 UTC) #1
ulan
lgtm
6 years ago (2014-11-24 09:48:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/752063002/1
6 years ago (2014-11-24 09:49:52 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/99)
6 years ago (2014-11-24 10:00:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/752063002/20001
6 years ago (2014-11-25 15:14:32 UTC) #8
commit-bot: I haz the power
6 years ago (2014-11-25 15:42:25 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001)

Powered by Google App Engine
This is Rietveld 408576698