Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 751883002: Revert of Check that usage isn't empty when generateKey() is called (Closed)

Created:
6 years, 1 month ago by pdr.
Modified:
6 years, 1 month ago
Reviewers:
eroman, nharper, Ryan Sleevi
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Check that usage isn't empty when generateKey() is called (patchset #4 id:60001 of https://codereview.chromium.org/745443002/) Reason for revert: This patch caused the crypto/rsa-oaep-generate-non-extractable-key.html layouttest to fail on non-linux bots: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=crypto%2Frsa-oaep-generate-non-extractable-key.html&testType=layout-tests Original issue's description: > Check that usage isn't empty when generateKey() is called > > BUG=425645 > > Committed: https://crrev.com/f723e1609b239219b3fb88e8db06562ad56a8af9 > Cr-Commit-Position: refs/heads/master@{#305350} TBR=rsleevi@chromium.org,eroman@chromium.org,nharper@chromium.org NOTREECHECKS=true NOTRY=true BUG=425645 Committed: https://crrev.com/4ec50f25659b4754cb5328d02c650944988bc598 Cr-Commit-Position: refs/heads/master@{#305374}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -147 lines) Patch
M content/child/webcrypto/nss/rsa_key_nss.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/child/webcrypto/nss/sym_key_nss.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/child/webcrypto/openssl/ec_key_openssl.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/child/webcrypto/openssl/rsa_key_openssl.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/child/webcrypto/openssl/sym_key_openssl.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/child/webcrypto/status.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/child/webcrypto/status.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/child/webcrypto/test/aes_cbc_unittest.cc View 4 chunks +18 lines, -17 lines 0 comments Download
M content/child/webcrypto/test/aes_gcm_unittest.cc View 1 chunk +3 lines, -14 lines 0 comments Download
M content/child/webcrypto/test/aes_kw_unittest.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/child/webcrypto/test/ecdsa_unittest.cc View 2 chunks +2 lines, -15 lines 0 comments Download
M content/child/webcrypto/test/hmac_unittest.cc View 4 chunks +3 lines, -17 lines 0 comments Download
M content/child/webcrypto/test/rsa_ssa_unittest.cc View 11 chunks +39 lines, -55 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
pdr.
Created Revert of Check that usage isn't empty when generateKey() is called
6 years, 1 month ago (2014-11-22 21:33:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/751883002/1
6 years, 1 month ago (2014-11-22 21:34:04 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-22 21:34:29 UTC) #3
commit-bot: I haz the power
6 years, 1 month ago (2014-11-22 21:35:18 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4ec50f25659b4754cb5328d02c650944988bc598
Cr-Commit-Position: refs/heads/master@{#305374}

Powered by Google App Engine
This is Rietveld 408576698