Issue 751863002: Revert of Enable inobject double fields unboxing for 64-bit archs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 751863002: Revert of Enable inobject double fields unboxing for 64-bit archs. (Closed)

Created:
6 years, 1 month ago by Igor Sheludko

Modified:
6 years, 1 month ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Project:
v8

Visibility:
Public.

More Reviews

Description

Revert of Enable inobject double fields unboxing for 64-bit archs. (patchset #3 id:40001 of https://codereview.chromium.org/753503002/) Reason for revert: GCMole and gc-stress issues. Original issue's description: > Enable inobject double fields unboxing for 64-bit archs. TBR=verwaest@chromium.org NOTREECHECKS=true NOTRY=true

Patch Set 1 #

Created: 6 years, 1 month ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -5 lines)			Patch
M	src/globals.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/heap/mark-compact.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/heap/store-buffer.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-unboxed-doubles.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Igor Sheludko

Created Revert of Enable inobject double fields unboxing for 64-bit archs.

6 years, 1 month ago (2014-11-22 20:32:24 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/751863002/1

6 years, 1 month ago (2014-11-22 20:32:49 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1)

Expand Messages | Collapse Messages