Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 751833003: Version 3.30.33.4 (cherry-pick) (Closed)

Created:
6 years ago by Yang
Modified:
6 years ago
Reviewers:
Jakob Kummerow
CC:
v8-dev, ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@3.30
Project:
v8
Visibility:
Public.

Description

Version 3.30.33.4 (cherry-pick) Merged 5bea77f786469ac81d1e2805b2d268d394520c27 Fix disabling all break points from within the debug event callback. BUG=chromium:432493 LOG=N R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=fe794eab84d4f5ab7455163b23d7e6a59eab6562

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -7 lines) Patch
M src/debug.h View 3 chunks +14 lines, -3 lines 0 comments Download
M src/debug.cc View 5 chunks +6 lines, -3 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/regress/regress-crbug-432493.js View 1 chunk +57 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Yang
6 years ago (2014-11-24 09:50:33 UTC) #1
Jakob Kummerow
lgtm
6 years ago (2014-11-24 09:51:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/751833003/1
6 years ago (2014-11-24 09:56:52 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/113) v8_linux_dbg on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg/builds/1345)
6 years ago (2014-11-24 09:58:04 UTC) #6
Yang
6 years ago (2014-11-24 10:22:06 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fe794eab84d4f5ab7455163b23d7e6a59eab6562.

Powered by Google App Engine
This is Rietveld 408576698