'Paste' & 'Paste as plain text' should check edit_flags.

'Paste' & 'Paste as plain text' should check edit_flags.

'Paste' and 'Paste as plain text' should check edit_flags first
before making clipboard call, as clipboard call is expensive and should
not happen unnecessarily.

BUG=439774
Committed: https://crrev.com/866d23354e939aeb50a5516b72313b1c36115e2b
Cr-Commit-Position: refs/heads/master@{#307467}

[Deepak, 2014-12-07 08:07:26]

deepak.m1@samsung.com changed reviewers:
+ lazyboy@chromium.org

[Deepak, 2014-12-07 08:07:27]

PTAL.

[lazyboy, 2014-12-09 03:57:58]

https://chromiumcodereview.appspot.com/751823004/diff/1/chrome/browser/render...
File chrome/browser/renderer_context_menu/render_view_context_menu.cc (right):

https://chromiumcodereview.appspot.com/751823004/diff/1/chrome/browser/render...
chrome/browser/renderer_context_menu/render_view_context_menu.cc:1204: return
paste_enabled;
nit: This seems a bit verbose, isn't sth like:

if (!(params_.edit_flags & WebContextMenuData::CanPaste))
  return false;

sounds cleaner? I don't think it hurts readability at all.
WDYT?

[Deepak, 2014-12-09 04:48:07]

Thanks for review and sharing your thoughts.
Changes done.
PTAL at my changes.

https://codereview.chromium.org/751823004/diff/1/chrome/browser/renderer_cont...
File chrome/browser/renderer_context_menu/render_view_context_menu.cc (right):

https://codereview.chromium.org/751823004/diff/1/chrome/browser/renderer_cont...
chrome/browser/renderer_context_menu/render_view_context_menu.cc:1204: return
paste_enabled;
On 2014/12/09 03:57:58, lazyboy wrote:
> nit: This seems a bit verbose, isn't sth like:
> 
> if (!(params_.edit_flags & WebContextMenuData::CanPaste))
>   return false;
> 
> sounds cleaner? I don't think it hurts readability at all.
> WDYT?

Done.

[lazyboy, 2014-12-09 13:25:22]

lgtm

[Deepak, 2014-12-09 13:25:43]

The CQ bit was checked by deepak.m1@samsung.com

[commit-bot: I haz the power, 2014-12-09 13:25:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/751823004/20001

[commit-bot: I haz the power, 2014-12-09 14:16:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-12-09 14:17:31]

Patchset 2 (id:??) landed as
https://crrev.com/866d23354e939aeb50a5516b72313b1c36115e2b
Cr-Commit-Position: refs/heads/master@{#307467}