Remove Picture deletion listeners.

Remove Picture deletion listeners.

Looks like we can just have ~SkPicture put the message on the bus directly.

BUG=skia:3144
Committed: https://skia.googlesource.com/skia/+/04c96950554b4e416755c5bc23022674518a6e8b

[mtklein, 2014-11-21 21:07:18]

mtklein@google.com changed reviewers:
+ mtklein@google.com, reed@google.com, robertphillips@google.com

[reed1, 2014-11-21 23:05:17]

reed@google.com changed required reviewers:
+ robertphillips@google.com

[reed1, 2014-11-21 23:05:17]

api lgtm

[robertphillips, 2014-11-24 15:13:16]

lgtm + a nit

https://codereview.chromium.org/751663002/diff/20001/include/core/SkPicture.h
File include/core/SkPicture.h (right):

https://codereview.chromium.org/751663002/diff/20001/include/core/SkPicture.h...
include/core/SkPicture.h:206: // Sent via SkMessageBus from destructor.
fUniqueID ?

[mtklein, 2014-11-24 16:05:05]

https://codereview.chromium.org/751663002/diff/20001/include/core/SkPicture.h
File include/core/SkPicture.h (right):

https://codereview.chromium.org/751663002/diff/20001/include/core/SkPicture.h...
include/core/SkPicture.h:206: // Sent via SkMessageBus from destructor.
On 2014/11/24 15:13:15, robertphillips wrote:
> fUniqueID ?

Done, though I think this is probably a net negative for readability.  It
doesn't seem valuable to have an fPrefix on struct fields, particularly when the
struct has no methods.  Access to the field will always have a prefix (e.g.
msg.uniqueID, ms->uniqueID) that makes it completely unambiguous that it's a
member.

[mtklein, 2014-11-24 16:05:16]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-11-24 16:05:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/751663002/40001

[commit-bot: I haz the power, 2014-11-24 16:21:03]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/04c96950554b4e416755c5bc23022674518a6e8b

[reed1, 2014-11-24 16:24:37]

On 2014/11/24 16:05:05, mtklein wrote:
> https://codereview.chromium.org/751663002/diff/20001/include/core/SkPicture.h
> File include/core/SkPicture.h (right):
> 
>
https://codereview.chromium.org/751663002/diff/20001/include/core/SkPicture.h...
> include/core/SkPicture.h:206: // Sent via SkMessageBus from destructor.
> On 2014/11/24 15:13:15, robertphillips wrote:
> > fUniqueID ?
> 
> Done, though I think this is probably a net negative for readability.  It
> doesn't seem valuable to have an fPrefix on struct fields, particularly when
the
> struct has no methods.  Access to the field will always have a prefix (e.g.
> msg.uniqueID, ms->uniqueID) that makes it completely unambiguous that it's a
> member.

fwiw, as a reader of skia code, not seeing the fPrefix is slightly jarring, just
because its different.