WebRTC Android APK trybot recipe

scripts/slave/recipe_modules/webrtc/gclient_config.py

+# Copyright 2013 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+from RECIPE_MODULES.gclient import CONFIG_CTX
+from slave.recipe_config import BadConf
+from slave.recipe_modules.gclient.config import ChromeSvnSubURL,\
+  ChromiumSvnSubURL
+
+
+@CONFIG_CTX(includes=['chromium', '_webrtc_additional_solutions'])
+def webrtc_android_apk_try_builder(c):
+  c.target_os = ['android']
+
+  c.solutions[0].custom_deps['src/third_party/webrtc'] = (
+       'http://webrtc.googlecode.com/svn/trunk/webrtc')

[kjellander_chromium, 2013/11/20 14:29:16]

I don't have a good way of getting the revision at this stage either, so I add
this and append the revision to it in the recipe. Not ideal but the best I could
come up with.

[iannucci, 2013/11/21 00:33:59]

If you look in DEPS, for webkit we have a webkit_trunk and a webkit_revision.
You should make webrtc do the same thing, and then you can tweak both of them as
custom_vars instead of custom_deps.

[kjellander_chromium, 2013/11/22 12:49:09]

It's correct we have a webrtc_revision variable, but we don't have one for
webrtc_trunk unfortunately. We could create one and use that approach, but as
we're about to retire the WebRTC stable branch and actually point to trunk, I
think it's better to wait for that to happen and then use webrtc_revision as you
suggest. Until then I think this is the way to go.
I added a TODO for it here and in the recipe.

+
+
+@CONFIG_CTX()
+def _webrtc_additional_solutions(c):
+  """Helper config for loading additional solutions.
+
+  The webrtc-limited solution contains non-redistributable code.
+  The webrtc.DEPS solution pulls in additional DEPS for building Android tests
+  and running special test setups.
+  """
+  if c.GIT_MODE:
+    raise BadConf('WebRTC only supports svn')
+
+  s = c.solutions.add()
+  s.name = 'webrtc-limited'
+  s.url = ChromeSvnSubURL(c, 'chrome-internal', 'trunk', 'webrtc-limited')
+
+  s = c.solutions.add()
+  s.name = 'webrtc.DEPS'
+  s.url = ChromiumSvnSubURL(c, 'chrome', 'trunk', 'deps', 'third_party',
+                            'webrtc', 'webrtc.DEPS')

[iannucci, 2013/11/21 00:33:59]

Why not just put this in the other method?

[kjellander_chromium, 2013/11/22 12:49:09]

I plan to use it for all our "normal" bots later on. webrtc.DEPS is actually
used for more than Android nowadays too (so I clarified that comment).