WebRTC Android APK trybot recipe

scripts/slave/recipe_modules/webrtc/chromium_config.py

+# Copyright 2013 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+from slave.recipe_config_types import Path
+
+from RECIPE_MODULES.chromium import CONFIG_CTX
+
+#TODO(kjellander): Remove duplication vs the chromium_android recipe module's
+# android_defaults config.
+@CONFIG_CTX(includes=['ninja', 'static_library'])

[iannucci, 2013/11/18 18:49:26]

May want to check for / raise BadConf

TARGET_PLATFORM == 'android'
TARGET_ARCH == 'arm'
TARGET_BITS == 32

?

[kjellander_chromium, 2013/11/20 14:29:16]

I added platform and architecture checks only for the
webrtc_android_apk_try_builder. I'll leave the bits for now.
I moved the config into chromium/config.py instead.

+def webrtc_android_defaults(c):
+  c.compile_py.default_targets=['All']
+  c.gyp_env.GYP_CROSSCOMPILE = 1

[iannucci, 2013/11/18 18:49:26]

Do you know when this is supposed to be set? We could theoretically have
chromium's BASE set this automatically. I suspect that its value is inconsistent
though.

[kjellander_chromium, 2013/11/20 14:29:16]

I assume it's needed only when compiling for another target architecture than
the host (i.e. only Android for now)

+  c.gyp_env.GYP_GENERATORS.add('ninja')

[iannucci, 2013/11/18 18:49:26]

This should already be set, since you're including 'ninja'

[kjellander_chromium, 2013/11/20 14:29:16]

Done.

+  c.gyp_env.GYP_GENERATOR_FLAGS['default_target'] = 'All'

[iannucci, 2013/11/18 18:49:26]

this is redundant with compile_py.default_targets (or at least it should be)

[kjellander_chromium, 2013/11/20 14:29:16]

Right, I guess All is the default if nothing is specified (this was copied from
chromium_android).

+  gyp_defs = c.gyp_env.GYP_DEFINES
+  gyp_defs['fastbuild'] = 1
+  gyp_defs['OS'] = 'android'

[iannucci, 2013/11/18 18:49:26]

This gets me all the time... is 'OS' supposed to be the host OS, or the
destination OS?

Should we make the chromium module set OS == gyp_name_for(TARGET_PLATFORM)?

[kjellander_chromium, 2013/11/20 14:29:16]

I think it's the target OS in all cases, and the same as TARGET_PLATFORM, so
I'll give that a try.

+  gyp_defs['host_os'] = 'linux'
+  gyp_defs['gcc_version'] = 46
+  gyp_defs['order_text_section'] = Path(
+    '[CHECKOUT]', 'orderfiles', 'orderfile.out')
+  gyp_defs['target_arch'] = 'arm'
+
+@CONFIG_CTX(includes=['webrtc_android_defaults', 'default_compiler', 'goma'])
+def webrtc_android_apk_try_builder(c):
+  c.compile_py.default_targets = ['android_builder_webrtc']
+  c.gyp_env.GYP_GENERATOR_FLAGS['default_target'] = 'android_builder_webrtc'
+  c.gyp_env.GYP_DEFINES['include_tests'] = 1