Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Side by Side Diff: Source/bindings/v8/WorkerScriptDebugServer.cpp

Issue 75163003: Remove deprecated v8::External::New calls (blink side) (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2011 Google Inc. All rights reserved. 2 * Copyright (c) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 v8::HandleScope scope(m_isolate); 56 v8::HandleScope scope(m_isolate);
57 v8::Local<v8::Context> debuggerContext = v8::Debug::GetDebugContext(); 57 v8::Local<v8::Context> debuggerContext = v8::Debug::GetDebugContext();
58 v8::Context::Scope contextScope(debuggerContext); 58 v8::Context::Scope contextScope(debuggerContext);
59 59
60 ASSERT(!m_listener); 60 ASSERT(!m_listener);
61 m_listener = listener; 61 m_listener = listener;
62 62
63 ensureDebuggerScriptCompiled(); 63 ensureDebuggerScriptCompiled();
64 v8::Local<v8::Object> debuggerScript = m_debuggerScript.newLocal(m_isolate); 64 v8::Local<v8::Object> debuggerScript = m_debuggerScript.newLocal(m_isolate);
65 ASSERT(!debuggerScript->IsUndefined()); 65 ASSERT(!debuggerScript->IsUndefined());
66 v8::Debug::SetDebugEventListener2(&WorkerScriptDebugServer::v8DebugEventCall back, v8::External::New(this)); 66 v8::Debug::SetDebugEventListener2(&WorkerScriptDebugServer::v8DebugEventCall back, v8::External::New(m_isolate, this));
67 67
68 v8::Handle<v8::Function> getScriptsFunction = v8::Local<v8::Function>::Cast( debuggerScript->Get(v8::String::NewSymbol("getWorkerScripts"))); 68 v8::Handle<v8::Function> getScriptsFunction = v8::Local<v8::Function>::Cast( debuggerScript->Get(v8::String::NewSymbol("getWorkerScripts")));
69 v8::Handle<v8::Value> value = V8ScriptRunner::callInternalFunction(getScript sFunction, debuggerScript, 0, 0, m_isolate); 69 v8::Handle<v8::Value> value = V8ScriptRunner::callInternalFunction(getScript sFunction, debuggerScript, 0, 0, m_isolate);
70 if (value.IsEmpty()) 70 if (value.IsEmpty())
71 return; 71 return;
72 ASSERT(!value->IsUndefined() && value->IsArray()); 72 ASSERT(!value->IsUndefined() && value->IsArray());
73 v8::Handle<v8::Array> scriptsArray = v8::Handle<v8::Array>::Cast(value); 73 v8::Handle<v8::Array> scriptsArray = v8::Handle<v8::Array>::Cast(value);
74 for (unsigned i = 0; i < scriptsArray->Length(); ++i) 74 for (unsigned i = 0; i < scriptsArray->Length(); ++i)
75 dispatchDidParseSource(listener, v8::Handle<v8::Object>::Cast(scriptsArr ay->Get(v8::Integer::New(i, m_isolate)))); 75 dispatchDidParseSource(listener, v8::Handle<v8::Object>::Cast(scriptsArr ay->Get(v8::Integer::New(i, m_isolate))));
76 } 76 }
(...skipping 29 matching lines...) Expand all
106 if (m_listener) 106 if (m_listener)
107 m_listener->didContinue(); 107 m_listener->didContinue();
108 } 108 }
109 109
110 void WorkerScriptDebugServer::quitMessageLoopOnPause() 110 void WorkerScriptDebugServer::quitMessageLoopOnPause()
111 { 111 {
112 // Nothing to do here in case of workers since runMessageLoopOnPause will ch eck for paused state after each debugger command. 112 // Nothing to do here in case of workers since runMessageLoopOnPause will ch eck for paused state after each debugger command.
113 } 113 }
114 114
115 } // namespace WebCore 115 } // namespace WebCore
OLDNEW
« Source/bindings/templates/interface.cpp ('K') | « Source/bindings/v8/V8EventListenerList.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698