Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Side by Side Diff: Source/bindings/templates/interface.cpp

Issue 75163003: Remove deprecated v8::External::New calls (blink side) (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 {% extends 'interface_base.cpp' %} 1 {% extends 'interface_base.cpp' %}
2 2
3 3
4 {##############################################################################} 4 {##############################################################################}
5 {% macro attribute_configuration(attribute) %} 5 {% macro attribute_configuration(attribute) %}
6 {% set getter_callback_name = 6 {% set getter_callback_name =
7 '%sV8Internal::%sAttributeGetterCallback' % 7 '%sV8Internal::%sAttributeGetterCallback' %
8 (interface_name, attribute.name) 8 (interface_name, attribute.name)
9 if not attribute.constructor_type else 9 if not attribute.constructor_type else
10 '{0}V8Internal::{0}ConstructorGetter'.format(interface_name) %} 10 '{0}V8Internal::{0}ConstructorGetter'.format(interface_name) %}
(...skipping 189 matching lines...) Expand 10 before | Expand all | Expand 10 after
200 {% filter runtime_enabled(method.runtime_enabled_function_name) %} 200 {% filter runtime_enabled(method.runtime_enabled_function_name) %}
201 {{install_custom_signature(method)}} 201 {{install_custom_signature(method)}}
202 {% endfilter %} 202 {% endfilter %}
203 {% endif %} 203 {% endif %}
204 {% endfilter %} 204 {% endfilter %}
205 {% endif %}{# install_custom_signature #} 205 {% endif %}{# install_custom_signature #}
206 {% endfor %} 206 {% endfor %}
207 {% for attribute in attributes if attribute.is_static %} 207 {% for attribute in attributes if attribute.is_static %}
208 {% set getter_callback_name = '%sV8Internal::%sAttributeGetterCallback' % 208 {% set getter_callback_name = '%sV8Internal::%sAttributeGetterCallback' %
209 (interface_name, attribute.name) %} 209 (interface_name, attribute.name) %}
210 functionTemplate->SetNativeDataProperty(v8::String::NewSymbol("{{attribute.n ame}}"), {{getter_callback_name}}, {{attribute.setter_callback_name}}, v8::Exter nal::New(0), static_cast<v8::PropertyAttribute>(v8::None), v8::Handle<v8::Access orSignature>(), static_cast<v8::AccessControl>(v8::DEFAULT)); 210 functionTemplate->SetNativeDataProperty(v8::String::NewSymbol("{{attribute.n ame}}"), {{getter_callback_name}}, {{attribute.setter_callback_name}}, v8::Exter nal::New(isolate, 0), static_cast<v8::PropertyAttribute>(v8::None), v8::Handle<v 8::AccessorSignature>(), static_cast<v8::AccessControl>(v8::DEFAULT));
haraken 2013/11/18 10:42:48 nbarth: Probably can you remove this file from the
Nils Barth (inactive) 2013/11/18 10:47:25 ? I don't understand. Jinja templates are in bindi
211 {% endfor %} 211 {% endfor %}
212 {% if constants %} 212 {% if constants %}
213 {{install_constants() | indent}} 213 {{install_constants() | indent}}
214 {% endif %} 214 {% endif %}
215 215
216 // Custom toString template 216 // Custom toString template
217 functionTemplate->Set(v8::String::NewSymbol("toString"), V8PerIsolateData::c urrent()->toStringTemplate()); 217 functionTemplate->Set(v8::String::NewSymbol("toString"), V8PerIsolateData::c urrent()->toStringTemplate());
218 return functionTemplate; 218 return functionTemplate;
219 } 219 }
220 220
(...skipping 136 matching lines...) Expand 10 before | Expand all | Expand 10 after
357 V8DOMWrapper::associateObjectWithWrapper<{{v8_class_name}}>(impl, &wrapperTy peInfo, wrapper, isolate, WrapperConfiguration::Independent); 357 V8DOMWrapper::associateObjectWithWrapper<{{v8_class_name}}>(impl, &wrapperTy peInfo, wrapper, isolate, WrapperConfiguration::Independent);
358 return wrapper; 358 return wrapper;
359 } 359 }
360 360
361 void {{v8_class_name}}::derefObject(void* object) 361 void {{v8_class_name}}::derefObject(void* object)
362 { 362 {
363 fromInternalPointer(object)->deref(); 363 fromInternalPointer(object)->deref();
364 } 364 }
365 365
366 {% endblock %} 366 {% endblock %}
OLDNEW
« no previous file with comments | « Source/bindings/scripts/code_generator_v8.pm ('k') | Source/bindings/tests/results/V8SupportTestInterface.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698