ozone: Add initial build support for xkbcommon

ozone: Add initial build support for xkbcommon

This adds a use_xkbcommon variable that allows usage of libxkbcommon in
the build. Turn this on for linux ozone builds (except embedded builds).

BUG=430194
TEST=build

Committed: https://crrev.com/304529e882cd79826c1b8f222a0e855da2ba8a59
Cr-Commit-Position: refs/heads/master@{#308204}

[spang, 2014-12-08 22:21:18]

spang@chromium.org changed reviewers:
+ brettw@chromium.org

[spang, 2014-12-10 18:47:26]

ping :)

[brettw, 2014-12-12 20:11:42]

Is there a reason for having this separate flag and define? It seems that this
would only ever be used for ozone. If that's the case, can we just key off of
the existing OZONE defines rather than adding a new one to every single file
compiled in the project?

[spang, 2014-12-12 20:14:31]

On 2014/12/12 20:11:42, brettw wrote:
> Is there a reason for having this separate flag and define? It seems that this
> would only ever be used for ozone. If that's the case, can we just key off of
> the existing OZONE defines rather than adding a new one to every single file
> compiled in the project?

I think we need to be careful about doing that because USE_OZONE is used for a
lot of ports and some of them have very minimal system libs avaliable. Builds
like chromecast won't have xkbcommon.

I can reduce the scope of the ifdef if the worry is having it defined for all
files - that's easily done.

[spang, 2014-12-12 20:18:19]

On 2014/12/12 20:14:31, spang wrote:
> On 2014/12/12 20:11:42, brettw wrote:
> > Is there a reason for having this separate flag and define? It seems that
this
> > would only ever be used for ozone. If that's the case, can we just key off
of
> > the existing OZONE defines rather than adding a new one to every single file
> > compiled in the project?
> 
> I think we need to be careful about doing that because USE_OZONE is used for a
> lot of ports and some of them have very minimal system libs avaliable. Builds
> like chromecast won't have xkbcommon.
> 
> I can reduce the scope of the ifdef if the worry is having it defined for all
> files - that's easily done.

Removed.. we'll add it directly it to the 1-2 targets that need it.

[spang, 2014-12-12 22:31:30]

spang@chromium.org changed reviewers:
+ kpschoedel@chromium.org

[spang, 2014-12-12 22:31:31]

+kpschoedel

[spang, 2014-12-12 22:32:07]

On 2014/12/12 20:18:19, spang wrote:
> On 2014/12/12 20:14:31, spang wrote:
> > On 2014/12/12 20:11:42, brettw wrote:
> > > Is there a reason for having this separate flag and define? It seems that
> this
> > > would only ever be used for ozone. If that's the case, can we just key off
> of
> > > the existing OZONE defines rather than adding a new one to every single
file
> > > compiled in the project?
> > 
> > I think we need to be careful about doing that because USE_OZONE is used for
a
> > lot of ports and some of them have very minimal system libs avaliable.
Builds
> > like chromecast won't have xkbcommon.
> > 
> > I can reduce the scope of the ifdef if the worry is having it defined for
all
> > files - that's easily done.
> 
> Removed.. we'll add it directly it to the 1-2 targets that need it.

Moved the GN build support into ui/events/ozone/BUILD.gn.

[brettw, 2014-12-12 22:33:41]

I don't see the #define in the GN build.

[spang, 2014-12-12 22:37:43]

On 2014/12/12 22:33:41, brettw wrote:
> I don't see the #define in the GN build.

Oops :(

[brettw, 2014-12-12 22:46:33]

lgtm

[spang, 2014-12-12 22:48:14]

The CQ bit was checked by spang@chromium.org

[commit-bot: I haz the power, 2014-12-12 22:49:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/751623003/60001

[kpschoedel, 2014-12-12 22:52:07]

Thanks! with unnecessary social LGTM.

https://codereview.chromium.org/751623003/diff/60001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/751623003/diff/60001/build/common.gypi#newcod...
build/common.gypi:709: # Libxkbcommon ussage.
niit.

[spang, 2014-12-12 22:52:43]

The CQ bit was unchecked by spang@chromium.org

[spang, 2014-12-12 22:53:26]

The CQ bit was checked by spang@chromium.org

[commit-bot: I haz the power, 2014-12-12 22:54:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/751623003/80001

[commit-bot: I haz the power, 2014-12-13 00:32:43]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2014-12-13 00:34:51]

Patchset 5 (id:??) landed as
https://crrev.com/304529e882cd79826c1b8f222a0e855da2ba8a59
Cr-Commit-Position: refs/heads/master@{#308204}