Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: build/secondary/tools/grit/grit_rule.gni

Issue 751613006: Add enable_hangout_services_extension flag to GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/features.gni ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/secondary/tools/grit/grit_rule.gni
diff --git a/build/secondary/tools/grit/grit_rule.gni b/build/secondary/tools/grit/grit_rule.gni
index 8726927e57990e8f1a167a6fc2b775036a0bc862..d49c4ed55022171c504d8a1e7bb036ddf9b7a600 100644
--- a/build/secondary/tools/grit/grit_rule.gni
+++ b/build/secondary/tools/grit/grit_rule.gni
@@ -182,8 +182,9 @@ if (enable_google_now) {
if (enable_webrtc) {
grit_defines += [ "-D", "enable_webrtc" ]
}
-# Note: enable_hangout_services_extension is omitted. It is never set in the
-# GYP build. Need to figure out what it's for.
+if (enable_hangout_services_extension) {
+ grit_defines += [ "-D", "enable_hangout_services_extension" ]
+}
if (enable_task_manager) {
grit_defines += [ "-D", "enable_task_manager" ]
}
« no previous file with comments | « build/config/features.gni ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698