Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 751613006: Add enable_hangout_services_extension flag to GN build. (Closed)

Created:
6 years ago by brettw
Modified:
6 years ago
Reviewers:
bemasc
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add enable_hangout_services_extension flag to GN build. This does not yet control anything, but is now hooked up to the C++ and grit defines as in GYP. R=bemasc@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/2954bd38c7dfd9e5c36fae26ccaafb9088605bf8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M build/config/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M build/config/features.gni View 1 chunk +5 lines, -0 lines 0 comments Download
M build/secondary/tools/grit/grit_rule.gni View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
brettw
6 years ago (2014-12-01 20:49:37 UTC) #2
bemasc
lgtm
6 years ago (2014-12-01 20:56:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/751613006/1
6 years ago (2014-12-01 22:18:08 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years ago (2014-12-01 22:18:10 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2954bd38c7dfd9e5c36fae26ccaafb9088605bf8 Cr-Commit-Position: refs/heads/master@{#306270}
6 years ago (2014-12-01 22:23:25 UTC) #8
brettw
6 years ago (2014-12-01 22:23:38 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2954bd38c7dfd9e5c36fae26ccaafb9088605bf8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698