Source/core/paint/BoxPainter.cpp - Issue 751573002: Use viewportConstrainedVisibleContentRect() to get the scrolling offset

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/paint/BoxPainter.cpp

Issue 751573002: Use viewportConstrainedVisibleContentRect() to get the scrolling offset (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/paint/BoxPainter.cpp

diff --git a/Source/core/paint/BoxPainter.cpp b/Source/core/paint/BoxPainter.cpp

index 6044ebb7427cb00aaab132ea3bc1f481f32c6b15..0c9d3b827683df4bb5b57f6e440b6ab54e76fc66 100644

--- a/Source/core/paint/BoxPainter.cpp

+++ b/Source/core/paint/BoxPainter.cpp

@@ -697,7 +697,7 @@ void BoxPainter::calculateBackgroundImageGeometry(RenderBoxModelObject& obj, con

if (fixedBackgroundPaintsInLocalCoordinates(obj))

viewportRect.setLocation(IntPoint());

else if (FrameView* frameView = obj.view()->frameView())

- viewportRect.setLocation(IntPoint(frameView->scrollOffsetForFixedPosition()));

+ viewportRect.setLocation(IntPoint(frameView->scrollOffsetForViewportConstrainedObjects()));

if (paintContainer) {

IntPoint absoluteContainerOffset = roundedIntPoint(paintContainer->localToAbsolute(FloatPoint()));

« Source/core/frame/FrameView.h ('K') | « Source/core/frame/FrameView.cpp ('k') | Source/core/rendering/RenderLayerClipper.cpp » ('j') | no next file with comments »