Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 751553005: Sync execCommand() and queryCommand*() IDL with spec (Closed)

Created:
6 years ago by philipj_slow
Modified:
6 years ago
CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, Inactive, rwlbuis
Project:
blink
Visibility:
Public.

Description

Sync execCommand() and queryCommand*() IDL with spec https://html.spec.whatwg.org/multipage/dom.html#the-document-object Both Firefox Nightly and IE11 pass all of the added tests, making this change likely Web compatible. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186980

Patch Set 1 #

Patch Set 2 : fix one test failure #

Patch Set 3 : rebase on https://codereview.chromium.org/788153003/ #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -16 lines) Patch
M LayoutTests/editing/execCommand/arguments-combinations.html View 1 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/editing/execCommand/arguments-combinations-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/execCommand/insertImage-src.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/Document/missing-arguments.html View 1 chunk +7 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/Document/missing-arguments-expected.txt View 2 chunks +6 lines, -0 lines 0 comments Download
M Source/core/dom/Document.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.idl View 1 chunk +6 lines, -9 lines 0 comments Download

Messages

Total messages: 21 (7 generated)
philipj_slow
PTAL. Ought to land after https://codereview.chromium.org/769053004/ even though it'll work either way.
6 years ago (2014-12-08 14:13:20 UTC) #2
tkent
+yosin
6 years ago (2014-12-08 23:46:50 UTC) #4
philipj_slow
I see that I'm failing some tests, one trivial and one because document.execCommand("InsertImage",false) will now ...
6 years ago (2014-12-09 15:01:22 UTC) #5
philipj_slow
fix one test failure
6 years ago (2014-12-09 15:02:32 UTC) #6
Yuta Kitamura
lgtm
6 years ago (2014-12-10 09:55:53 UTC) #7
philipj_slow
rebase on https://codereview.chromium.org/788153003/
6 years ago (2014-12-10 12:26:48 UTC) #8
philipj_slow
The second test failure is fixed by https://codereview.chromium.org/788153003/ and if this CL will work if ...
6 years ago (2014-12-10 12:27:13 UTC) #9
philipj_slow
rebase
6 years ago (2014-12-11 13:04:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/751553005/60001
6 years ago (2014-12-11 13:05:18 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/40905)
6 years ago (2014-12-11 15:40:37 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/751553005/60001
6 years ago (2014-12-11 17:02:34 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/40946)
6 years ago (2014-12-11 19:25:55 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/751553005/60001
6 years ago (2014-12-11 19:47:34 UTC) #20
commit-bot: I haz the power
6 years ago (2014-12-11 20:41:12 UTC) #21
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186980

Powered by Google App Engine
This is Rietveld 408576698