Issue 751553004: CL for perf tryjob ThreadSafeRefCountedStringImpl Linux blink_perf.dom

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 751553004: CL for perf tryjob ThreadSafeRefCountedStringImpl Linux blink_perf.dom

Created:
6 years ago by hiroshige

Modified:
6 years ago

Reviewers:
Alexander Potapenko

CC:
blink-reviews, blink-reviews-wtf_chromium.org, aandrey+blink_chromium.org, Mikhail

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

CL for perf tryjob

Patch Set 1 #

Total comments: 1

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -84 lines)			Patch
	M	Source/wtf/text/StringImpl.h	View		3 chunks	+12 lines, -7 lines	1 comment	Download
	M	Tools/run-perf-test.cfg	View		1 chunk	+5 lines, -77 lines	0 comments	Download

Messages

Total messages: 2 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Alexander Potapenko

6 years ago (2014-12-08 11:46:57 UTC) #2

https://codereview.chromium.org/751553004/diff/1/Source/wtf/text/StringImpl.h
File Source/wtf/text/StringImpl.h (right):

https://codereview.chromium.org/751553004/diff/1/Source/wtf/text/StringImpl.h...
Source/wtf/text/StringImpl.h:306: WTF_ANNOTATE_HAPPENS_AFTER(&m_refCount);
Please do not use WTF_ANNOTATE_HAPPENS_AFTER.
They were intended to aid TSan v1, which couldn't comprehend atomics, and which
is retired now.
TSan v2 is able to understand atomic-based synchronization, and adding excessive
happens-before annotations may mask actual errors in the implementation.
I think we should plan removing all WTF_ANNOTATE_HAPPENS_{BEFORE,AFTER} from
Blink at some point.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages