Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 751533002: Revert of Revert of Disable telemetry tests for Mac 10.9. (Closed)

Created:
6 years, 1 month ago by Finnur
Modified:
6 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Disable telemetry tests for Mac 10.9. (patchset #1 id:1 of https://codereview.chromium.org/744283002/) Reason for revert: This re-enabling of tests has left a trail of redness on Mac 10.9 (more than one failure). If you expect tests to fail as a result of re-enabling again, then please watch the tree and disable the ones failing (assuming that is the appropriate course of action in the first place, which I'm not sure of). Original issue's description: > Revert of Disable telemetry tests for Mac 10.9. (patchset #2 id:20001 of https://codereview.chromium.org/706703003/) > > Reason for revert: > Second attempt to re-enable tests. I think there may still be one test failure, but we can disable that one test. If there's more than one, revert this. > > Original issue's description: > > Disable telemetry tests for Mac 10.9. > > > > The telemetry tests are failing consistently on OSX 10.9. > > > > BUG=420615 > > R=tonyg@chromium.org > > > > Committed: https://crrev.com/5503de1eeae0437c1f8160d69b04d6241bc5e974 > > Cr-Commit-Position: refs/heads/master@{#303114} > > TBR=phajdan.jr@chromium.org,tonyg@chromium.org,garykac@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=420615 > > Committed: https://crrev.com/10e58e6dfbe4d9dae5841ceb9eb0180cce1aac14 > Cr-Commit-Position: refs/heads/master@{#305096} TBR=phajdan.jr@chromium.org,tonyg@chromium.org,garykac@chromium.org,dtu@chromium.org NOTREECHECKS=true NOTRY=true BUG=420615 Committed: https://crrev.com/8ef425c1d3058afabd36fd9226385c142ba5f280 Cr-Commit-Position: refs/heads/master@{#305200}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16 lines) Patch
M testing/buildbot/chromium.mac.json View 2 chunks +0 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Finnur
Created Revert of Revert of Disable telemetry tests for Mac 10.9.
6 years, 1 month ago (2014-11-21 11:26:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/751533002/1
6 years, 1 month ago (2014-11-21 11:27:25 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-21 11:27:51 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8ef425c1d3058afabd36fd9226385c142ba5f280 Cr-Commit-Position: refs/heads/master@{#305200}
6 years, 1 month ago (2014-11-21 11:28:45 UTC) #4
sullivan
6 years ago (2014-12-02 19:01:19 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/734433004/ by sullivan@chromium.org.

The reason for reverting is: Failures fixed in
https://codereview.chromium.org/720413006/, these tests pass locally for me on
Mac 10.9.

Powered by Google App Engine
This is Rietveld 408576698