Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 75153002: Verify that video.crossOrigin performs no preflighting. (Closed)

Created:
7 years, 1 month ago by sof
Modified:
7 years, 1 month ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Verify that video.crossOrigin performs no preflighting. Verify that a video element CORS fetch doesn't generate a preflight request and loads the cross-origin resource ok. R=jochen,kbr BUG=173727 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162293

Patch Set 1 #

Total comments: 1

Patch Set 2 : add missing doctype decl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M LayoutTests/http/tests/security/resources/video-cross-origin-allow.php View 1 chunk +5 lines, -0 lines 0 comments Download
A + LayoutTests/http/tests/security/video-cross-origin-via-dom.html View 1 2 chunks +5 lines, -4 lines 0 comments Download
A + LayoutTests/http/tests/security/video-cross-origin-via-dom-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
sof
At your leisure, please take a look. Goes with https://codereview.chromium.org/68173029/ https://codereview.chromium.org/69813010/ (sorry, I couldn't see ...
7 years, 1 month ago (2013-11-18 10:07:47 UTC) #1
jochen (gone - plz use gerrit)
lgtm https://codereview.chromium.org/75153002/diff/1/LayoutTests/http/tests/security/video-cross-origin-via-dom.html File LayoutTests/http/tests/security/video-cross-origin-via-dom.html (right): https://codereview.chromium.org/75153002/diff/1/LayoutTests/http/tests/security/video-cross-origin-via-dom.html#newcode1 LayoutTests/http/tests/security/video-cross-origin-via-dom.html:1: <html> nit. <!doctype html>
7 years, 1 month ago (2013-11-18 12:00:12 UTC) #2
sof
On 2013/11/18 12:00:12, jochen wrote: > lgtm > > https://codereview.chromium.org/75153002/diff/1/LayoutTests/http/tests/security/video-cross-origin-via-dom.html > File LayoutTests/http/tests/security/video-cross-origin-via-dom.html (right): > ...
7 years, 1 month ago (2013-11-18 12:15:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/75153002/50001
7 years, 1 month ago (2013-11-18 17:34:01 UTC) #4
sof
ah, who ticked the commit button? This will fail without https://codereview.chromium.org/69813010/ (just wanted everyone to ...
7 years, 1 month ago (2013-11-18 18:19:53 UTC) #5
Ken Russell (switch to Gerrit)
lgtm
7 years, 1 month ago (2013-11-18 19:00:50 UTC) #6
abarth-chromium
On 2013/11/18 18:19:53, sof wrote: > ah, who ticked the commit button? I did. I'll ...
7 years, 1 month ago (2013-11-18 19:20:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/75153002/50001
7 years, 1 month ago (2013-11-19 10:17:03 UTC) #8
sof
On 2013/11/18 19:20:44, abarth wrote: > On 2013/11/18 18:19:53, sof wrote: > > ah, who ...
7 years, 1 month ago (2013-11-19 10:19:06 UTC) #9
commit-bot: I haz the power
7 years, 1 month ago (2013-11-19 10:59:56 UTC) #10
Message was sent while issue was closed. 
Change committed as 162293

Powered by Google App Engine
This is Rietveld 408576698