Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 751513002: Assert to protect against polymorphic string loads fires on valid stores. (Closed)

Created:
6 years, 1 month ago by mvstanton
Modified:
6 years, 1 month ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Assert to protect against polymorphic string loads fires on valid stores. BUG=435477 LOG=N R=jarin@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/cf572694fedb97347e8354d9ec5b13d61940476d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M src/hydrogen.cc View 1 chunk +3 lines, -1 line 0 comments Download
A + test/mjsunit/regress/regress-435477.js View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mvstanton
Hi Jaro, could you have a look? --Michael
6 years, 1 month ago (2014-11-21 09:19:43 UTC) #1
Jarin
lgtm
6 years, 1 month ago (2014-11-21 09:57:32 UTC) #2
mvstanton
6 years, 1 month ago (2014-11-21 10:29:14 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cf572694fedb97347e8354d9ec5b13d61940476d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698