Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Issue 751493003: Add support for import@async (Closed)

Created:
6 years, 1 month ago by abarth-chromium
Modified:
6 years, 1 month ago
Reviewers:
esprehn
CC:
esprehn, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Add support for import@async We don't have a good way of testing this behavior without introducing a race. Ideally we'd unit test it, but we don't really have unit tests yet. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/6cea614668c7d4affa68173cb1e6ef7a0c0f2a83

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M sky/engine/core/html/HTMLImportElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
6 years, 1 month ago (2014-11-21 07:00:31 UTC) #1
esprehn
lgtm
6 years, 1 month ago (2014-11-21 07:03:06 UTC) #2
abarth-chromium
6 years, 1 month ago (2014-11-21 07:14:53 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6cea614668c7d4affa68173cb1e6ef7a0c0f2a83 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698