Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 75133005: Updating Maps pixel test for stability (Closed)

Created:
7 years, 1 month ago by bajones
Modified:
7 years, 1 month ago
CC:
chromium-reviews, joi+watch-content_chromium.org, piman+watch_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Added a RAF wait, support for devicePixelRatios other than 1, screenshot archiving, and test expectations support BUG=143317 R=kbr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236021

Patch Set 1 #

Patch Set 2 : Added screenshot archiving and test expectations #

Total comments: 4

Patch Set 3 : Added TODO comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -9 lines) Patch
M content/test/gpu/gpu_tests/maps.py View 1 2 5 chunks +89 lines, -3 lines 0 comments Download
A + content/test/gpu/gpu_tests/maps_expectations.py View 1 2 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
bajones
Please take a look. This seems to have resolved at least some of the issues ...
7 years, 1 month ago (2013-11-19 01:00:14 UTC) #1
Ken Russell (switch to Gerrit)
lgtm https://codereview.chromium.org/75133005/diff/40001/content/test/gpu/gpu_tests/maps.py File content/test/gpu/gpu_tests/maps.py (right): https://codereview.chromium.org/75133005/diff/40001/content/test/gpu/gpu_tests/maps.py#newcode35 content/test/gpu/gpu_tests/maps.py:35: MapsValidator.SpinWaitOnRAF(tab, 3) Please add a TODO about removing ...
7 years, 1 month ago (2013-11-19 01:22:30 UTC) #2
bajones
https://codereview.chromium.org/75133005/diff/40001/content/test/gpu/gpu_tests/maps.py File content/test/gpu/gpu_tests/maps.py (right): https://codereview.chromium.org/75133005/diff/40001/content/test/gpu/gpu_tests/maps.py#newcode35 content/test/gpu/gpu_tests/maps.py:35: MapsValidator.SpinWaitOnRAF(tab, 3) On 2013/11/19 01:22:30, Ken Russell wrote: > ...
7 years, 1 month ago (2013-11-19 18:27:30 UTC) #3
bajones
7 years, 1 month ago (2013-11-19 18:29:49 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r236021 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698