Close duplicated handle on windows.

base/threading/platform_thread_win.cc

Index: base/threading/platform_thread_win.cc
diff --git a/base/threading/platform_thread_win.cc b/base/threading/platform_thread_win.cc
index e9752ba21394c671d1d84214e4cd65078bd940f3..ef0fb002849ccf0099a752fd265a609da2f6b11b 100644
--- a/base/threading/platform_thread_win.cc
+++ b/base/threading/platform_thread_win.cc
@@ -76,6 +76,9 @@ DWORD __stdcall ThreadFunc(void* params) {
   ThreadIdNameManager::GetInstance()->RemoveName(
       platform_handle,
       PlatformThread::CurrentId());
+
+  CloseHandle(platform_handle);

[zhaoqin, 2013/11/28 16:07:33]

Actually I am not sure this is the correct solution.

The handle is created  hereusing DuplicateHandle. Then the newly created handle
is passed to ThreadIdNameManager::RegisterThread and added into a list.
see src/base/threading/thread_id_name_manager.cc

void ThreadIdNameManager::RegisterThread(PlatformThreadHandle::Handle handle,
                                         PlatformThreadId id) {
  AutoLock locked(lock_);
  thread_id_to_handle_[id] = handle;
  thread_handle_to_interned_name_[handle] =
      name_to_interned_name_[kDefaultName];
}

So if you close the handle here, the reference in thread_id_to_handle_[id] will
be invalid.

[dsinclair, 2013/11/28 16:13:40]

Right, but the line immediately above:

  ThreadIdNameManager::GetInstance()->RemoveName(
       platform_handle,
       PlatformThread::CurrentId());

Removes the handle from the maps.

It's cleared from the thread_handle_to_interned_name_ map on line 100 and from
the thread_id_to_handle_ map on line 110 of thread_id_name_manager.cc.  

[zhaoqin, 2013/11/28 16:25:41]

I see, my bad.
In that case, should CloseHandle be called in ThreadIdNameManager::RemoveName
right after the handle is removed?

[dsinclair, 2013/11/28 16:31:07]

I don't think so, ThreadIdNameManager doesn't know the handle should be closed.
It just knows it shouldn't have the mapping to it anymore.

As well, how to close the handle as it's platform dependent.

+
   return NULL;
 }