Close duplicated handle on windows.

base/threading/platform_thread_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/threading/platform_thread.h"
 
 #include "base/debug/alias.h"
 #include "base/debug/profiler.h"
 #include "base/logging.h"
 #include "base/threading/thread_id_name_manager.h"
@@ skipping 58 matching lines @@
   ThreadIdNameManager::GetInstance()->RegisterThread(
       platform_handle,
       PlatformThread::CurrentId());
 
   delete thread_params;
   delegate->ThreadMain();
 
   ThreadIdNameManager::GetInstance()->RemoveName(
       platform_handle,
       PlatformThread::CurrentId());
+
+  /* Close the duplicated handle created for the thread name mapping. */
+  DuplicateHandle(
+      GetCurrentProcess(),
+      platform_handle,
+      GetCurrentProcess(),
+      NULL,

[zhaoqin, 2013/11/26 20:35:56]

This NULL will cause a handle leak.
It seems that Windows will create a handle no matter if you pass NULL or not. I
think CloseHandle below should just do the trick. You do not need
DuplicateHandle here.

[dsinclair, 2013/11/28 15:51:14]

Done.

+      0,
+      FALSE,
+      DUPLICATE_CLOSE_SOURCE);
+
+  CloseHandle(platform_handle);

[zhaoqin, 2013/11/26 20:35:56]

If you use DUPLICATE_CLOSE_SOURCE above in DuplicateHandle, it will close the
source handle regardless of any error status returned. So CloseHandle here
should fail.

[dsinclair, 2013/11/28 15:51:14]

Done.

+
   return NULL;
 }
 
 // CreateThreadInternal() matches PlatformThread::Create(), except that
 // |out_thread_handle| may be NULL, in which case a non-joinable thread is
 // created.
 bool CreateThreadInternal(size_t stack_size,
                           PlatformThread::Delegate* delegate,
                           PlatformThreadHandle* out_thread_handle) {
   unsigned int flags = 0;
@@ skipping 141 matching lines @@
     case kThreadPriority_RealtimeAudio:
       ::SetThreadPriority(handle.handle_, THREAD_PRIORITY_TIME_CRITICAL);
       break;
     default:
       NOTREACHED() << "Unknown priority.";
       break;
   }
 }
 
 }  // namespace base