Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 751303003: Move tracing_impl code to mojo/common (Closed)

Created:
6 years ago by jamesr
Modified:
6 years ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Move tracing_impl code to mojo/common This moves the tracing code and mojoms from sky/viewer/services/ to mojo/common/ in anticipation of refactoring these to be more widely usable. This doesn't actually change behaviors yet. BUG=436639 R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/0aa2bfb1b36eb358e6dab37485ba4ad9a69c5562

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -136 lines) Patch
M mojo/common/BUILD.gn View 2 chunks +19 lines, -0 lines 0 comments Download
A + mojo/common/tracing.mojom View 1 chunk +1 line, -1 line 0 comments Download
A mojo/common/tracing_impl.h View 1 chunk +34 lines, -0 lines 0 comments Download
A + mojo/common/tracing_impl.cc View 5 chunks +13 lines, -13 lines 0 comments Download
M sky/tools/debugger/prompt/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M sky/tools/debugger/prompt/prompt.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/viewer/BUILD.gn View 3 chunks +1 line, -3 lines 0 comments Download
D sky/viewer/services/tracing.mojom View 1 chunk +0 lines, -10 lines 0 comments Download
D sky/viewer/services/tracing_impl.h View 1 chunk +0 lines, -31 lines 0 comments Download
D sky/viewer/services/tracing_impl.cc View 1 chunk +0 lines, -71 lines 0 comments Download
M sky/viewer/viewer.cc View 5 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
jamesr
Part 1 of N, where N is still unknown.
6 years ago (2014-11-25 23:03:28 UTC) #2
abarth-chromium
lgtm
6 years ago (2014-11-25 23:19:12 UTC) #3
jamesr
6 years ago (2014-11-26 00:23:48 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
0aa2bfb1b36eb358e6dab37485ba4ad9a69c5562 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698