Switch the Clang plugin to use RecursiveASTVisitor.

tools/clang/plugins/tests/test.sh

 #!/bin/bash
 #
 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 #
 # Hacky, primitive testing: This runs the style plugin for a set of input files
 # and compares the output with golden result files.
 
 E_BADARGS=65
@@ skipping 15 matching lines @@
 do_testcase() {
   local flags=""
   if [ -e "${3}" ]; then
     flags="$(cat "${3}")"
   fi
 
   if [ "$(uname -s)" = "Darwin" ]; then
     flags="${flags} -isysroot $(xcrun --show-sdk-path) -stdlib=libstdc++"
   fi
 
+  flags="${flags} -Xclang -plugin-arg-find-bad-constructs \
+      -Xclang with-ast-visitor"
+
   local output="$("${CLANG_PATH}" -fsyntax-only -Wno-c++11-extensions \
       -Wno-inconsistent-missing-override \
       -Xclang -load -Xclang "${PLUGIN_PATH}" \
       -Xclang -add-plugin -Xclang find-bad-constructs ${flags} ${1} 2>&1)"
   local diffout="$(echo "${output}" | diff - "${2}")"
   if [ "${diffout}" = "" ]; then
     echo "PASS: ${1}"
   else
     failed_any_test=yes
     echo "FAIL: ${1}"
@@ skipping 39 matching lines @@
   do_testcase "${input}" "${input%cpp}txt" "${input%cpp}flags"
 done
 
 for input in *.c; do
   do_testcase "${input}" "${input%c}txt" "${input%c}flags"
 done
 
 if [[ "${failed_any_test}" ]]; then
   exit ${E_FAILEDTEST}
 fi