Switch the Clang plugin to use RecursiveASTVisitor.

tools/clang/plugins/FindBadConstructsConsumer.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file defines a bunch of recurring problems in the Chromium C++ code.
 //
 // Checks that are implemented:
 // - Constructors/Destructors should not be inlined if they are of a complex
 //   class type.
 // - Missing "virtual" keywords on methods that should be virtual.
 // - Non-annotated overriding virtual methods.
 // - Virtual methods with nonempty implementations in their headers.
 // - Classes that derive from base::RefCounted / base::RefCountedThreadSafe
 //   should have protected or private destructors.
 // - WeakPtrFactory members that refer to their outer class should be the last
 //   member.
 // - Enum types with a xxxx_LAST or xxxxLast const actually have that constant
 //   have the maximal value for that type.
 
 #include "clang/AST/AST.h"
 #include "clang/AST/ASTConsumer.h"
 #include "clang/AST/Attr.h"
 #include "clang/AST/CXXInheritance.h"
+#include "clang/AST/RecursiveASTVisitor.h"
 #include "clang/AST/TypeLoc.h"
 #include "clang/Basic/SourceManager.h"
 
 #include "ChromeClassTester.h"
 #include "Options.h"
 
 namespace chrome_checker {
 
 // Searches for constructs that we know we don't want in the Chromium code base.
-class FindBadConstructsConsumer : public ChromeClassTester {
+class FindBadConstructsConsumer
+    : public clang::RecursiveASTVisitor<FindBadConstructsConsumer>,
+      public ChromeClassTester {
  public:
   FindBadConstructsConsumer(clang::CompilerInstance& instance,
                             const Options& options);
 
+  // RecursiveASTVisitor:
+  bool VisitDecl(clang::Decl* decl);
+
   // ChromeClassTester overrides:
   void CheckChromeClass(clang::SourceLocation record_location,
                         clang::CXXRecordDecl* record) override;
   void CheckChromeEnum(clang::SourceLocation enum_location,
                        clang::EnumDecl* enum_decl) override;
 
  private:
   // The type of problematic ref-counting pattern that was encountered.
   enum RefcountIssue { None, ImplicitDestructor, PublicDestructor };
 
@@ skipping 42 matching lines @@
   unsigned diag_protected_non_virtual_dtor_;
   unsigned diag_weak_ptr_factory_order_;
   unsigned diag_bad_enum_last_value_;
   unsigned diag_note_inheritance_;
   unsigned diag_note_implicit_dtor_;
   unsigned diag_note_public_dtor_;
   unsigned diag_note_protected_non_virtual_dtor_;
 };
 
 }  // namespace chrome_checker