Issue 751193002: Fix compile break on official Windows builder from disabling scoped_refptr<T> conversions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 751193002: Fix compile break on official Windows builder from disabling scoped_refptr<T> conversions. (Closed)

Created:
6 years ago by dcheng

Modified:
6 years ago

Reviewers:
Nico

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Fix compile break on official Windows builder from disabling scoped_refptr<T> conversions. BUG=110610 R=thakis@chromium.org TBR=thakis@chromium.org Committed: https://crrev.com/c3f4fd73576af0a6632d7477c1da99d6f29dfc00 Cr-Commit-Position: refs/heads/master@{#305577}

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/ui/webui/help/version_updater_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (1 generated)

dcheng

I scanned the file to see if there's any obvious breakage, and it /seems/ OK...

6 years ago (2014-11-25 03:53:21 UTC) #2

dcheng

Committed patchset #1 (id:1) manually as c3f4fd73576af0a6632d7477c1da99d6f29dfc00 (tree was closed).

6 years ago (2014-11-25 03:56:16 UTC) #4

commit-bot: I haz the power

6 years ago (2014-11-25 03:56:17 UTC) #5

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/c3f4fd73576af0a6632d7477c1da99d6f29dfc00
Cr-Commit-Position: refs/heads/master@{#305577}