Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 751183003: Expose set_source service command for functions (Closed)

Created:
6 years ago by Cutch
Modified:
6 years ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Expose set_source service command for functions - Can change signatures - Currently only works for unexecuted functions. R=rmacnak@google.com Committed: https://code.google.com/p/dart/source/detail?r=42124

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -5 lines) Patch
M runtime/vm/object.h View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M runtime/vm/parser.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/parser.cc View 2 chunks +37 lines, -1 line 0 comments Download
M runtime/vm/service.cc View 1 2 3 4 3 chunks +36 lines, -3 lines 0 comments Download
M runtime/vm/service_test.cc View 1 2 chunks +122 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Cutch
6 years ago (2014-12-04 23:17:45 UTC) #2
rmacnak
lgtm w/ comment https://codereview.chromium.org/751183003/diff/40001/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/751183003/diff/40001/runtime/vm/parser.cc#newcode1129 runtime/vm/parser.cc:1129: ASSERT(members.functions().Length() == 1); Actually, make this ...
6 years ago (2014-12-04 23:28:05 UTC) #3
Cutch
https://codereview.chromium.org/751183003/diff/40001/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/751183003/diff/40001/runtime/vm/parser.cc#newcode1129 runtime/vm/parser.cc:1129: ASSERT(members.functions().Length() == 1); On 2014/12/04 23:28:04, rmacnak wrote: > ...
6 years ago (2014-12-04 23:31:46 UTC) #4
Cutch
6 years ago (2014-12-04 23:35:31 UTC) #5
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as 42124 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698